100% coverage

exodist · Feb 5, 2010 · 427b9f5 · 427b9f5
1 parent ec86418
commit 427b9f5
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/lib/Object/Quick.pm b/lib/Object/Quick.pm
@@ -287,12 +287,13 @@ sub import {
     my $class = shift;
     return $class->$PARAM( 'import', @_ ) if ref( $class );
 
-    my %args = map { $_ => 1 } grep { $_ && m/^-/ } @_;
+    my %args = map { $_ => 1 } grep { m/^-/ } @_;
 
     my @names = grep { $_ ? m/^-/ ? undef : $_ : undef } @_[0 .. 2];
-    my @default = qw/obj method clear/;
     if ( $args{ -obj } || $args{ -all }) {
-        $names[$_] ||= $default[$_] for 0 .. 2;
+        $names[0] ||= 'obj';
+        $names[1] ||= 'method';
+        $names[2] ||= 'clear';
     }
 
     my %subs;

diff --git a/t/40-Quick-Import.t b/t/40-Quick-Import.t
@@ -3,6 +3,7 @@ use strict;
 use warnings;
 
 use Test::More;
+use Test::Exception;
 
 my $CLASS = 'Object::Quick';
 use_ok( $CLASS );
@@ -105,4 +106,22 @@ ok( main::K->can( 'm' ), "Imported 'm'" );
 ok( main::K->can( 'c' ), "Imported 'c'" );
 #}}}
 
+{
+    package Test::Twice;
+    use Object::Quick;
+    use Test::More;
+    use Test::Exception;
+
+    my @warnings;
+
+    $SIG{ __WARN__ } = sub { push @warnings => @_ };
+
+    Object::Quick->import( 'obj' );
+
+    is_deeply( \@warnings, [], "No warnings" );
+
+    lives_ok { Object::Quick->import( 'obj' ) } "Double import";
+    like( @warnings[0], qr/Not overriding function: Test::Twice::obj/, "Not overriden" );
+}
+
 done_testing();