Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Static wormhole types showing undefined [v1.5.4] #864

Closed
eophten opened this issue Oct 15, 2019 · 9 comments
Closed

[BUG] Static wormhole types showing undefined [v1.5.4] #864

eophten opened this issue Oct 15, 2019 · 9 comments

Comments

@eophten
Copy link

eophten commented Oct 15, 2019

Following upgrade to v1.5.4, static wormhole types are showing as undefined -> undefined

This is following the setup of new tables, fixing of tables, and clearing of cache.

chrome_vsWwvikgcG

@eophten eophten changed the title Static wormhole types showing undefined. [BUG] Static wormhole types showing undefined [v1.5.4] Oct 15, 2019
@eophten
Copy link
Author

eophten commented Oct 16, 2019

This appears like it may be related to the transition between v1.5.3 and v1.5.4. New systems added may not appear in an undefined state, still confirming.

@leesolway
Copy link

leesolway commented Oct 16, 2019

I had this issue, i did the following..

  • Updated composer (just to make sure :D)
  • Upgraded the eve_universe database as per the release notes
  • Flushed the Redis cache
  • Removed anything in cache directory
  • Rebuilt the system / static indexes in /admin

I am not sure if the steps are related or not, but hope it helps.

@eophten
Copy link
Author

eophten commented Oct 16, 2019

  • Updated composer (just to make sure :D)

A pilot who was docked in a kspace station led me to finding this: he received a getUniverseStationData() not found error shortly after login which, extremely helpfully, suggested updating composer. (This error and others were also reflected in the error.log, also extremely helpfully).

@exodus4d Is it possible to surface the error mismatches of composer packages on the /setup page? Similarly, would it be possible to surface last log lines or an error log count in some way through the admin or setup interfaces?

  • Upgraded the eve_universe database as per the release notes

I completely missed this step (and the release notes entirely, https://github.com/exodus4d/pathfinder/releases for anyone else as blind as myself) and will perform this step at my next opportunity.

With the database installation notes in mind (https://github.com/exodus4d/pathfinder/wiki/Database), whereby pathfinder leverages ESI for the database data and the initial database only for a cache warming, would this only impact performance as opposed to data? Or are there calls pathfinder makes for static data which is not checked through ESI?

This may be my misunderstanding this "Since v1.4.0 Pathfinder had full ESI API support. All static data is loaded over ESI and cached in eve_universe DB. → The old SDE DB is no longer needed." note from the installation documentation.

  • Flushed the Redis cache

Currently not leveraging Redis.

  • Removed anything in cache directory
  • Rebuilt the system / static indexes in /admin

Both completed.

This was extremely helpful.

Current status of our pathfinder (with all release notes changes EXCEPT eve_database): new wormholes (as our chain has now cycled) are reflecting static information correctly. Only the previous existing system (home hole) is still reflecting undefined static information.

@exodus4d
Copy link
Owner

exodus4d commented Oct 17, 2019 via email

@eophten
Copy link
Author

eophten commented Oct 18, 2019

I have updated composer and the getUniverseStationData() error is no longer present. We are still seeing undefined static information for the home hole as well as no longer seeing a class type hint (H, L, N, C1-5) on the system bubble in map nor in the system information subwindow.

@exodus4d
Copy link
Owner

exodus4d commented Oct 18, 2019 via email

@eophten
Copy link
Author

eophten commented Oct 18, 2019

When setting up a new eve_universe database (create database, setup tables, fix columns) from /setup, i receive this error on fix columns action: Column not found: 1054 Unknown column 'factionId' in 'field list' [/opt/www/pathfinder/app/lib/db/sql.php:226]'. At this point, /setup becomes unavailable for any further access until i drop the schema and begin again.

Error on Fix columns

@mrurb
Copy link

mrurb commented Oct 19, 2019

@eophten This is a cache problem, please clear redis after clicking fix column

@exodus4d
Copy link
Owner

exodus4d commented Nov 2, 2019

@mrurb Agree! MySQL table "Schema"s are cached for (I think 60s). This is OK because table structure does not change that often.
If new columns/tables wer added/changed after an upgrade on /setup page, you schould always clear the cache (/tmp/cache dir or Redis cache DB) - or wait until cache data becomes invalid (60s)...

I thought about clearing cached Schemas automatic after DB update on /setup but it turns out to be a bit tricky... Retrieving the cache keys for delete is not possible (There is no public method provided by the framework). So I build my own method that rebuilds the key for delete... But for now this method is not used and still on testing:

public function clearSchemaCache() : bool {
$f3 = self::getF3();
$cache=\Cache::instance();
if(
$f3->CACHE && is_object($this->db) &&
$cache->exists($hash = $f3->hash($this->db->getDSN() . $this->table) . '.schema')
){
return (bool)$cache->clear($hash);
}
return false;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants