Discord webhook url validation fails

[xrem]

Looks like discord have changed domain name they were using:
https://support.discord.com/hc/en-us/articles/360042987951-Discordapp-com-is-now-Discord-com

Validation on UI needs to be fixed:

[xrem]

Related backend method;

pathfinder/app/Model/Pathfinder/MapModel.php

Lines 394 to 400 in 62dc991

	protected function validate_WebHookURL(string $key, string $val, string $type) : bool {
	$valid = true;
	if( !empty($val) ){
	$hosts = [
	'slack' => ['hooks.slack.com'],
	'discord' => ['discordapp.com', 'ptb.discordapp.com']
	];

Related frontend validation regexps:

pathfinder/public/templates/dialog/map.html

Line 255 in 62dc991

<input name="discordWebHookURLRally" type="url" class="form-control" id="{{discordWebHookURLRallyId}}" value="{{discordWebHookURLRally}}" placeholder="https://discordapp.com/api/webhooks/XXXYYYZZZ" data-type-error="No valid URL" pattern="^https://(\w+\.)?discordapp.com/.*" data-pattern-error="Wrong domain. https://discordapp.com/)" {{^discordRallyEnabled}}disabled{{/discordRallyEnabled}}>

pathfinder/public/templates/dialog/map.html

Line 152 in 62dc991

<input name="slackWebHookURL" type="url" class="form-control" id="{{slackWebHookURLId}}" value="{{slackWebHookURL}}" placeholder="https://hooks.slack.com/services/XXX/YYY/ZZZ" data-type-error="No valid URL" pattern="^https://hooks.slack.com/.*" data-pattern-error="Wrong domain. https://hooks.slack.com/)">

[xrem]

Going to fix this later today by myself.

Also, old webhooks with discordapp.com domain is still working, since discordapp.com redirects to discord.com

[cyberea]

Hello, @xrem was this fixed? Asking since the issue is still open and there is no reference to the commit. Thank you.

[xrem]

@cyberea nope.
I've left corporation that was used pathfinder, so there are no more points left for me to support private pathfinder instance on my host.

Also project looks kinda abandoned, so even if i contribute, author eventually won't magically appear here and approve PR :)