Allow disabling domain with false value in config

exoframejs · Aug 2, 2017 · 2a20f4d · 2a20f4d
1 parent 9b6dc10
commit 2a20f4d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/docker/start.js b/src/docker/start.js
@@ -19,7 +19,7 @@ module.exports = async ({image, username}) => {
 
   // generate host
   const defaultDomain = serverConfig.baseDomain ? `${name}${serverConfig.baseDomain}` : undefined;
-  const host = config.domain || defaultDomain;
+  const host = config.domain === undefined ? defaultDomain : config.domain;
 
   // generate env vars
   const Env = config.env ? Object.keys(config.env).map(key => `${key}=${config.env[key]}`) : [];

diff --git a/test/deploy.js b/test/deploy.js
@@ -154,7 +154,7 @@ module.exports = (server, token) =>
           name.replace(`-${deployId}`, ''),
           'Should have correct backend label'
         );
-        t.equal(container.Labels['traefik.frontend.rule'], 'Host:localhost', 'Should have correct frontend label');
+        t.notOk(container.Labels['traefik.frontend.rule'], 'Should not have frontend label');
         t.ok(container.NetworkSettings.Networks.exoframe, 'Should be in exoframe network');
 
         // cleanup

diff --git a/test/fixtures/html-project/exoframe.json b/test/fixtures/html-project/exoframe.json
@@ -1,5 +1,5 @@
 {
   "name": "test-html-deploy",
-  "domain": "localhost",
+  "domain": false,
   "restart": "no"
 }