Introduce header argument #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exogen
requested changes
Oct 28, 2019
exogen
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Thanks for the contribution!
@ruben-podadera, sorry I dropped the ball on wrapping up the #36 review, but this should hopefully meet your needs as well.
|
Thanks, this is now published in v5.1.0. Although there's one thing left behind: the docs in the README don't reflect the new option. Unfortunately I never set that up to be automatically generated. Open a PR if you'd like or I can do that this evening (just the update, not making it generated 😅). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this PR. It introduces an extra
--header <name=value>argument similar to #36 (but more minimal changes). It can be given multiple times.