Separate CLI from package.json:main #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offers protection against misbehaving dependencies as discovered in #17.
The issue is that some dependency, e.g.
modify-babel-preset
, might attempt torequire()
everything undernode_modules
as part of a module resolution strategy. This assumes thatrequire()
on any given module has no side effects (like running a script, for example, aspostinstall-build
does).So this separates
package.json:main
(index.js
) frompackage.json:bin
, which now points tocli.js
. Thus callingrequire('postinstall-build')
will no longer do the same thing as runningpostinstall-build
.Fixes #17. /cc @b1r3k