This repository has been archived by the owner on Jan 24, 2020. It is now read-only.
Studio Electron top level #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current bug here is that resizing the Exokit window also resizes the Electron window, which results in a recursion to window of size Edit: now the bug is that the engine window size is too small, and not correctly aligned: most likely this is a |
|
There's a few more bugs here, but the core functionality of super fast HTML + Exokit composition done by the OS should be working. There should also be no greenscreen bugs anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks the Studio render loop into two windows: the UI presented by Electron, and the 3D rendered by Exokit engine.
The Exokit engine window is aligned so that it appears to be part of the Electron window, although it is not -- the composition uses OS transparency to fake the effect.
The main reason for doing this is to make both Exokit rendering, and the HMTL UI rendering both fast regardless of the screen resolution used -- a 4K pixel transfer in either direction is too slow to not drop frames.