Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial dat support #1333

Closed
wants to merge 9,297 commits into from
Closed

Added initial dat support #1333

wants to merge 9,297 commits into from

Conversation

RangerMauve
Copy link
Collaborator

@RangerMauve RangerMauve commented Jul 18, 2019

Supports loading URLs from the dat:// protocol.

You can test it out with

exokit -x webvr dat://55861001e843ad2a0d0c1e1274c07cbc4fffa0a7cd83648741bc93c55c027acf/index.html
  • Ensures that all protocols get a :// after the protocol
  • Adds dat-fetch to the protocols list
  • Adds dat to the list f protocols to normalize

TODO:

  • Figure out how to get the Dat libraries to work without process.nextTick
  • Have the regex which detects protocols pull from the list of protocols in fetch.js?
  • Configure persistent storage for Dat archives

Closes #1213

avaer added 30 commits July 3, 2019 13:11
Make XMLHttpRequest accessors enumerable
Add WebGL 2 getInternalformatParameter method
Add WebGL 2 texStorage3D method
Add WebGL2 getProgramParameter arguments support
Globalize performance object in web workers as well
@RangerMauve RangerMauve requested a review from avaer July 18, 2019 03:43
@shawwn
Copy link
Contributor

shawwn commented Jul 18, 2019

I spent weeks arguing for decentralization in the context of webXR, and modulesio said it was dumb and highly unlikely. Yet here we are.

+1, hope this gets merged.

@avaer
Copy link
Member

avaer commented Jul 19, 2019

Thanks for bootstrapping this experimentation @RangerMauve!

@avaer
Copy link
Member

avaer commented Jul 19, 2019

@shawwn please review https://github.com/exokitxr/exokit/blob/master/CODE_OF_CONDUCT.md.

The Exokit Github repo is not the place for taking up personal issues with contributors.

@exokitxr exokitxr deleted a comment from shawwn Jul 19, 2019
@exokitxr exokitxr deleted a comment from shawwn Jul 19, 2019
@exokitxr exokitxr deleted a comment from shawwn Jul 19, 2019
@avaer
Copy link
Member

avaer commented Jul 20, 2019

These comments are not related to Mauve’s pull request. Can we take this to another channel?

@avaer
Copy link
Member

avaer commented Aug 5, 2019

Sorry @RangerMauve, this one got accidentally closed with a force-push. Did you want to re-open it? 🙏

@RangerMauve
Copy link
Collaborator Author

Yeah! Re-opening would be nice. I can't do it myself though. Otherwise I can open a new PR once I've made more progress. 😁

@exokitxr exokitxr deleted a comment from shawwn Aug 6, 2019
@avaer avaer mentioned this pull request Aug 6, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for custom protocols in resource loader
4 participants