Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#109 Make package compatible with psr/log 3.0 #111

Merged
merged 1 commit into from
Jun 7, 2022
Merged

#109 Make package compatible with psr/log 3.0 #111

merged 1 commit into from
Jun 7, 2022

Conversation

piotrmacha
Copy link
Contributor

@piotrmacha piotrmacha commented Jun 5, 2022

Description

Add additional psr/log versions to composer so the library is compabible with projects using newer psr/log version. Details as in #109

Motivation and context

It's impossible to use the library in projects with psr/log other than ^1.0. That excludes almost all modern projects with psr/log 3.0.

How has this been tested?

The existing tests pass.

Changes between psr/log major versions 1.0, 2.0 and 3.0 don't change the public interface but only add type hints according to minimal PHP versions for psr/log . The powerdns-php is using logger interface properly, so it doesn't require any code updates.

Screenshots (if appropriate)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • My pull request contains a title that can be used as a release note.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@trizz trizz self-assigned this Jun 7, 2022
@trizz trizz added the dependencies Upgrade or downgrade of project dependencies. label Jun 7, 2022
@trizz trizz merged commit 593eb08 into exonet:master Jun 7, 2022
@trizz
Copy link
Member

trizz commented Jun 7, 2022

Thanks for your PR. I've just release version 4.1.1 containing your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Upgrade or downgrade of project dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants