Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getShortName() method #112

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Added getShortName() method #112

merged 1 commit into from
Jun 17, 2022

Conversation

mvdgeijn
Copy link
Contributor

@mvdgeijn mvdgeijn commented Jun 15, 2022

Get only the subdomain from the ResourceRecord object.

Description

Get only the subdomain part from the ResourceRecord object

Motivation and context

This method creates an easy way to get only the subdomain part from the ResourceRecord. Handy in situations where the domain part is obvious or unnecessary.

How has this been tested?

Tested by using it in our project.

Screenshots (if appropriate)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • My pull request contains a title that can be used as a release note.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Get only the subdomain from the ResourceRecord object.
@trizz trizz self-assigned this Jun 17, 2022
@trizz trizz added the new-feature New features or options. label Jun 17, 2022
@trizz trizz merged commit 29d6ac1 into exonet:master Jun 17, 2022
@trizz
Copy link
Member

trizz commented Jun 20, 2022

Hi @mvdgeijn,

Thanks for your contribution! I've just tagged v4.2.0 which contains this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants