Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example how to add a slave domain #131

Merged
merged 4 commits into from
Feb 7, 2023

Conversation

jeroenvermeulen
Copy link
Contributor

Description

Added an example how to add a slave domain.

Motivation and context

It is not hard but it took me quite a while to find out exactly how to do it.

How has this been tested?

Tested on a live PowerDNS 4.7.3

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (if appropriate)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • My pull request contains a title that can be used as a release note.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@trizz trizz self-assigned this Feb 7, 2023
@trizz trizz added the documentation Solely about the documentation of the project. label Feb 7, 2023
@jeroenvermeulen
Copy link
Contributor Author

Can't figure out why exactly the CI went wrong.
You have some serious automation going on there.

@trizz
Copy link
Member

trizz commented Feb 7, 2023

Thanks for the example! No worries about the CI, I'll fix that later if it still fails after merging. Your previous PR is released this morning. This example will be released in a future version.

@trizz trizz merged commit d06c11d into exonet:master Feb 7, 2023
@jeroenvermeulen
Copy link
Contributor Author

@trizz Wow, really motivating how fast your guys are responding to PRs!
This is a very well maintained project, Dutch developers like to make quality in every aspect! 🇳🇱💪🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Solely about the documentation of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants