Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default port to 8081 #85

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Update default port to 8081 #85

merged 2 commits into from
Dec 20, 2021

Conversation

robbinjanssen
Copy link
Member

Description

This changes the default port to 8081, the default port used by PowerDNS

Motivation and context

When this library was first created, the docs of powerdns referenced the wrong port, it is time to correct this in the library as well :-)

Closes #84
Fixes #36

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • My pull request contains a title that can be used as a release note.
  • I have added the appropriate labels to my pull request (e.g. breaking-change, new-feature, bugfix).
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@robbinjanssen robbinjanssen added the breaking-change A breaking change for existing users. label Dec 20, 2021
@trizz trizz self-assigned this Dec 20, 2021
@trizz trizz merged commit 302c4f1 into master Dec 20, 2021
@trizz trizz deleted the rja/update-default-port branch December 20, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change for existing users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded PDNS port Why is the port 8001
2 participants