Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.8.1 #129

Merged
merged 9 commits into from
Jun 7, 2018
Merged

Conversation

aleksuss
Copy link
Contributor

@aleksuss aleksuss commented Jun 6, 2018

No description provided.

@aleksuss aleksuss self-assigned this Jun 6, 2018
CHANGELOG.md Outdated
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## 0.8.1 - 2018-06-06

- Changed `btc::Network` (de)serializing into/from string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we mark this change as ### Internal improvements and add comment that we've moved to rust-bitcoin 0.13.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

CHANGELOG.md Outdated

### Internal improvements

- Changed `btc::Network` (de)serializing into/from string (#128)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a dot at the end of the changelog entry. 🙃

CHANGELOG.md Outdated

- Changed `btc::Network` (de)serializing into/from string (#128)

- Updated to the [Rust-bitcoin 0.13.1](http`s://github.com/rust-bitcoin/rust-bitcoin/releases/tag/0.13)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like link is broken.
And it doesn't point to 0.13.1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately link to version 0.13.1 doesn't exist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe then remove this link at all? (and btw I've been talking about ` in the link)

@alekseysidorov alekseysidorov merged commit 3dcbc77 into exonum:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants