Add verification that we have already received a signature for the transaction for the selected input and validator #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
suggested changes
Mar 31, 2017
There was a problem hiding this comment.
Review as of 7a9581f.
Needs unit test(s) that demonstrate the change; the case in which the old code added several signatures for the same (txid, validator, input) triple.
Also, there is a problem with low-level serialization logic for keys of an MPT (see the line comment). Probably should be solved within exonum-core.
| @@ -254,6 +270,15 @@ impl<'a> AnchoringSchema<'a> { | |||
| } | |||
| } | |||
|
|
|||
| fn known_signature_id(msg: &MsgAnchoringSignature) -> Vec<u8> { | |||
There was a problem hiding this comment.
Maybe create a new Exonum datatype encompassing a (txid, validator, input_index) triple, and use it here? The current approach may be not sustainable; e.g., we may want to provide proofs to light clients and/or change general serialization logic in the future.
There was a problem hiding this comment.
I can not represent the custom type as &[u8].
alekseysidorov
changed the title
- Add verification that we have already received a signature for the transaction for the selected input and validator - Add secp256k1's hack for generate signatures with given nonce.
alekseysidorov
changed the title
slowli
approved these changes
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4