New project structure #677

bullet-tooth · 2019-01-31T14:41:29Z

Overview

This is a base branch that represents the next structure:

exonum-java-parent
|
 - exonum-java-binding-parent
    |
     - exonum-java-binding-common
   .....

It will be used as a base branch to merge into small separated changes.

Definition of Done

There is no TODOs left in the code
Change is covered by automated tests
The coding guidelines are followed
Public API has Javadoc
Method preconditions are checked and documented in the Javadoc of the method
Changelog is updated if needed (in case of notable or breaking changes)
The continuous integration build passes

# Conflicts: # pom.xml

dmitry-timofeev · 2019-02-05T09:31:09Z

...onum-java-binding-core/src/main/java/com/exonum/binding/storage/indices/ListSpliterator.java

@@ -32,7 +32,7 @@
 * associated with a given {@link com.exonum.binding.storage.database.Fork} is modified; not only
 * the source list.
 *
- * <p>This spliterator does not support specializations (e.g., {@link Spliterator.OfInt}).
+ * <p>This spliterator does not support specializations (e.g., {@link OfInt}).


It is not clear in the text what OfInt is.

Idea optimized it while merging with master :)

dmitry-timofeev · 2019-02-05T09:35:33Z

exonum-java-binding-parent/pom.xml

@@ -0,0 +1,647 @@
+<?xml version="1.0" encoding="UTF-8"?>


Git kind of breaks in such cases of moving and replacing original file, showing this one as brand new :)

dmitry-timofeev · 2019-02-05T09:37:22Z

pom.xml

  <description>
-    The Exonum Java Binding library.
+    The Exonum Java library.


The parent project of the Exonum Java libraries?

* Shell scripts adjust to the new structure

coveralls · 2019-02-05T11:59:59Z

Coverage remained the same at 85.666% when pulling 9e4d089 on project-new-structure into 7391aa5 on master.

MakarovS · 2019-02-05T16:57:37Z

pom.xml

-      <id>ossrh</id>
-      <url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url>
-    </repository>
-  </distributionManagement>

  <properties>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>


Do we need these two properties in both poms?

dmitry-timofeev

Where do you plan to update the Contribution Guide? Here, or in #680 ?

bullet-tooth · 2019-02-06T11:21:13Z

@dmitry-timofeev in #680

* Add maven plugins support to the corresponding project structure

* Light Client module

* New project structure: Change for supporting files

* fix path in travis scripts

bullet-tooth · 2019-02-08T08:00:23Z

.travis.yml

@@ -9,6 +9,8 @@ branches:
    - ejb-app-configuration


is it still needed?

…ect-new-structure

bullet-tooth · 2019-02-08T16:10:22Z

exonum-java-binding/core/rust/integration_tests/src/vm.rs

@@ -102,15 +102,15 @@ fn get_fakes_classpath_option() -> String {

 pub fn get_fakes_classpath() -> String {
    let classpath_txt_path =
-        project_root_dir().join("exonum-java-binding-fakes/target/ejb-fakes-classpath.txt");
+        project_root_dir().join("fakes/target/ejb-fakes-classpath.txt");


@skletsun @vitvakatu please check

dmitry-timofeev

👍

The rustfmt currently fails, would you fix that please?

dmitry-timofeev

Build is green ✔️

created new modules structure

b076b7f

bullet-tooth added the work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly! label Jan 31, 2019

bullet-tooth requested review from MakarovS and dmitry-timofeev January 31, 2019 14:41

Merge branch 'master' into project-new-structure

a516b08

bullet-tooth requested review from skletsun and vitvakatu January 31, 2019 14:46

bullet-tooth changed the title ~~Created new project structure~~ New project structure Feb 4, 2019

Merge branch 'master' into project-new-structure

b8356d0

# Conflicts: # pom.xml

dmitry-timofeev reviewed Feb 5, 2019

View reviewed changes

bullet-tooth added 3 commits February 5, 2019 12:59

fix javadoc

b7dfb92

fix pom description

eede56b

[New project structure] sh scripts change (#678)

69bbdc4

* Shell scripts adjust to the new structure

MakarovS reviewed Feb 5, 2019

View reviewed changes

dmitry-timofeev reviewed Feb 6, 2019

View reviewed changes

bullet-tooth added 2 commits February 6, 2019 17:04

[New project structure] plugins fix (#692)

741ed32

* Add maven plugins support to the corresponding project structure

[New project structure] Light Client module (#689)

4bae147

* Light Client module

bullet-tooth removed the work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly! label Feb 6, 2019

bullet-tooth added 3 commits February 7, 2019 14:23

[New project structure] Adjusting supporting files (#680)

57ce0ea

* New project structure: Change for supporting files

Merge branch 'master' into project-new-structure

f98e9d3

[New project structure] Fix travis path (#694)

ab36375

* fix path in travis scripts

bullet-tooth commented Feb 8, 2019

View reviewed changes

.travis.yml Outdated

@@ -9,6 +9,8 @@ branches:

- ejb-app-configuration

Copy link

Contributor Author

bullet-tooth Feb 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it still needed?

bullet-tooth added 3 commits February 8, 2019 10:04

rm tmp configuration

e746d9b

Merge remote-tracking branch 'origin/project-new-structure' into proj…

034088e

…ect-new-structure

rm branch configuration

0211f1c

dmitry-timofeev approved these changes Feb 8, 2019

View reviewed changes

bullet-tooth added 2 commits February 8, 2019 16:28

rename modules

df12de6

rename modules

f08a04f

bullet-tooth added 4 commits February 8, 2019 17:09

modify paths

dd44328

modify paths

0f2ead6

fix paths

2c04b18

fix paths

0d61dc5

bullet-tooth commented Feb 8, 2019

View reviewed changes

dmitry-timofeev approved these changes Feb 8, 2019

View reviewed changes

fix fmt

9e4d089

dmitry-timofeev approved these changes Feb 8, 2019

View reviewed changes

MakarovS approved these changes Feb 8, 2019

View reviewed changes

dmitry-timofeev merged commit affa85c into master Feb 8, 2019

dmitry-timofeev deleted the project-new-structure branch March 11, 2019 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New project structure #677

New project structure #677

bullet-tooth commented Jan 31, 2019 •

edited

dmitry-timofeev Feb 5, 2019

bullet-tooth Feb 5, 2019

dmitry-timofeev Feb 5, 2019

dmitry-timofeev Feb 5, 2019

coveralls commented Feb 5, 2019 •

edited

MakarovS Feb 5, 2019

dmitry-timofeev left a comment

bullet-tooth commented Feb 6, 2019

bullet-tooth Feb 8, 2019

bullet-tooth Feb 8, 2019

dmitry-timofeev left a comment

dmitry-timofeev left a comment

New project structure #677

New project structure #677

Conversation

bullet-tooth commented Jan 31, 2019 • edited

Overview

Definition of Done

dmitry-timofeev Feb 5, 2019

Choose a reason for hiding this comment

bullet-tooth Feb 5, 2019

Choose a reason for hiding this comment

dmitry-timofeev Feb 5, 2019

Choose a reason for hiding this comment

dmitry-timofeev Feb 5, 2019

Choose a reason for hiding this comment

coveralls commented Feb 5, 2019 • edited

MakarovS Feb 5, 2019

Choose a reason for hiding this comment

dmitry-timofeev left a comment

Choose a reason for hiding this comment

bullet-tooth commented Feb 6, 2019

bullet-tooth Feb 8, 2019

Choose a reason for hiding this comment

bullet-tooth Feb 8, 2019

Choose a reason for hiding this comment

dmitry-timofeev left a comment

Choose a reason for hiding this comment

dmitry-timofeev left a comment

Choose a reason for hiding this comment

bullet-tooth commented Jan 31, 2019 •

edited

coveralls commented Feb 5, 2019 •

edited