Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor message! and storage_value! #17

Closed
3 tasks done
vldm opened this issue Apr 4, 2017 · 3 comments
Closed
3 tasks done

Refactor message! and storage_value! #17

vldm opened this issue Apr 4, 2017 · 3 comments
Assignees
Milestone

Comments

@vldm
Copy link
Contributor

vldm commented Apr 4, 2017

  1. message! and storage_value! share same code to generate packed like structures, so we need to
    take out shared code to some module.
  2. message! and storage_value! has borrowed fields, so we cant derive deserialize for it
  3. message! should semantically depend from service
  4. there many boilerplate code that user need to write const MESSAGE_TYPE, const SIZE, const SERVICE_ID, and [from => to] to each field

For first iteration we decided:

@dj8yfo
Copy link
Contributor

dj8yfo commented Apr 8, 2017

#[$attr:meta] , #[$attr]

storage_value! (
    D#[doc="struct_description"]
struct ConfigReference {
        const SIZE = 40;
        D#[doc="it's actual from from Config reference"]
        F actual_from: u64    [00 => 08]
        F cfg_hash:    &Hash  [08 => 40]
    }
);

@defuz defuz mentioned this issue Apr 25, 2017
23 tasks
@defuz defuz added this to the Release 0.1 milestone Apr 25, 2017
@dj8yfo
Copy link
Contributor

dj8yfo commented Apr 26, 2017

@vldm can you please update the main subtasks you outlined for implementation with @defuz in task description (if there are some changes from what is currently in the header) and also create a separate task with points from second part - post 0.1 release?

@vldm
Copy link
Contributor Author

vldm commented Apr 26, 2017

@gisochre I decided not split this task, but keep it as tracking.

@vldm vldm self-assigned this May 9, 2017
stanislav-tkach pushed a commit to stanislav-tkach/exonum that referenced this issue Apr 4, 2018
added info about host and port used to server application
stanislav-tkach pushed a commit to stanislav-tkach/exonum that referenced this issue Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants