Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blockchain_explorer part of exonum crate #53

Closed
defuz opened this issue Apr 24, 2017 · 2 comments
Closed

Make blockchain_explorer part of exonum crate #53

defuz opened this issue Apr 24, 2017 · 2 comments
Assignees
Labels
discussion 💬 The design isn't finalized yet, feel free to participate in the discussion.
Milestone

Comments

@defuz
Copy link
Contributor

defuz commented Apr 24, 2017

  • Binary exonumctl seems like a natural part of exonum crate.
  • Common public API definitions too.
  • We may live with helpers.rs into exonum crate.

@alekseysidorov @gisochre Any thought?

@defuz defuz added the discussion 💬 The design isn't finalized yet, feel free to participate in the discussion. label Apr 25, 2017
@defuz defuz added this to the Release 0.1 milestone Apr 25, 2017
@dj8yfo
Copy link
Contributor

dj8yfo commented Apr 25, 2017

This looks like a natural first step to #66.

@alekseysidorov What should each Service return? BTreeMap<"endpoint_suffix", H> where H:iron::Handler ?

@dj8yfo
Copy link
Contributor

dj8yfo commented May 4, 2017

So these modules will be added to exonum/src/lib.rs?

pub mod api;
pub mod helpers;
pub mod explorer_api;

I propose further splitting helpers into loggin and clap_fabric and making explorer_api part of api, so that eventually it would look like:

pub mod iron_api;
pub mod clap_fabric;
pub mod logging;

I assume, this issue has to be coordinated with #61.

@defuz defuz closed this as completed in #94 May 15, 2017
stanislav-tkach pushed a commit to stanislav-tkach/exonum that referenced this issue Feb 10, 2018
Update Cargo.toml, README.md, rename crate
stanislav-tkach pushed a commit to stanislav-tkach/exonum that referenced this issue Apr 4, 2018
optional command to set a path to the configuration file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion 💬 The design isn't finalized yet, feel free to participate in the discussion.
Development

No branches or pull requests

3 participants