Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /benches and /testnet folders #54

Closed
defuz opened this issue Apr 25, 2017 · 6 comments
Closed

Remove /benches and /testnet folders #54

defuz opened this issue Apr 25, 2017 · 6 comments
Assignees
Labels
discussion 💬 The design isn't finalized yet, feel free to participate in the discussion.
Milestone

Comments

@defuz
Copy link
Contributor

defuz commented Apr 25, 2017

Does anyone remember why these folders exist? I would like to delete them.

@vldm Perhaps these pieces can be useful for deploying a test net, but I would still prefer to remove it in the current form.

cc @alekseysidorov @asmsoft @vldm

@defuz defuz added the discussion 💬 The design isn't finalized yet, feel free to participate in the discussion. label Apr 25, 2017
@vldm
Copy link
Contributor

vldm commented Apr 25, 2017

In profiling I used testnet, and this folder was removed in parallel merge.
So I propose move profiling to different repository. And keep testnet in it.
May be tx-generator, testnet, benches (modified one), profiling should be merged into separate sanity repository.

@defuz defuz mentioned this issue Apr 25, 2017
23 tasks
@defuz defuz added this to the Release 0.1 milestone Apr 25, 2017
@therustmonk
Copy link
Contributor

I've planned to repair testnet in: exonum/cryptocurrency#30
If we keep the same stuff here (testnet) we can unify supervisord config.

@vldm
Copy link
Contributor

vldm commented Jun 5, 2017

@deniskolodin +1 supervisord config should be in cryptocurrency.

@dj8yfo
Copy link
Contributor

dj8yfo commented Jun 7, 2017

@vldm it appears we can try tune leveldb cache a bit https://github.com/bitcoin/bitcoin/blob/master/src/leveldb/doc/benchmark.html#L373.
I beleive we are using the defaults of leveldb::options::Options

@dj8yfo
Copy link
Contributor

dj8yfo commented Jun 7, 2017

@defuz, is it Tx generator, running benchmarks or just Remove /benches and /testnet folders ?
What road to follow?

@defuz defuz closed this as completed Jul 10, 2017
@stanislav-tkach
Copy link
Contributor

#189

stanislav-tkach pushed a commit to stanislav-tkach/exonum that referenced this issue Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion 💬 The design isn't finalized yet, feel free to participate in the discussion.
Development

No branches or pull requests

5 participants