Add mempool params to node configuration #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
previously approved these changes
Jun 27, 2017
| /// Memory pool configuration parameters. | ||
| #[derive(Clone, Debug, Serialize, Deserialize)] | ||
| pub struct MemoryPoolConfig { | ||
| /// Maximum number of uncommited transactions. |
There was a problem hiding this comment.
One more config. 😄
There was a problem hiding this comment.
So we have to refactor structure of configurations to better usability.
exonum/src/node/state.rs
Outdated
| @@ -298,6 +298,7 @@ impl State { | |||
| validator_state: validator_id.map(ValidatorState::new), | |||
| public_key: public_key, | |||
| secret_key: secret_key, | |||
| mempool: mempool, | |||
There was a problem hiding this comment.
Field init shorthand can be used here:
...
secret_key: secret_key,
mempool,
...
|
@alekseysidorov just in case you're eager to make life easier #34 |
vldm
reviewed
Jun 27, 2017
exonum/src/node/mod.rs
Outdated
| impl Default for MemoryPoolConfig { | ||
| fn default() -> MemoryPoolConfig { | ||
| MemoryPoolConfig { | ||
| unconfirmed_txs_limit: 20000, |
There was a problem hiding this comment.
can you make default value x10 bigger?
7 tasks
dj8yfo
previously approved these changes
Jun 28, 2017
alekseysidorov
force-pushed
the
mempool-config-params
branch
from
28e361d
to
ba6aef5
Compare
alekseysidorov
force-pushed
the
mempool-config-params
branch
from
ba6aef5
to
83632d2
Compare
dj8yfo
approved these changes
Jun 29, 2017
stanislav-tkach
approved these changes
Jun 29, 2017
vldm
approved these changes
Jun 29, 2017
vldm
pushed a commit
that referenced
this pull request
Jul 13, 2017
Add mempool params to node configuration Former-commit-id: c832fe0ad8d1e3c558386e220420bfa0e9f0c3b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.