Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpc endpoints #224

Merged
merged 8 commits into from
Jul 12, 2017
Merged

Rpc endpoints #224

merged 8 commits into from
Jul 12, 2017

Conversation

vldm
Copy link
Contributor

@vldm vldm commented Jul 10, 2017

  • Add possibility to control pool.
  • Add possibility to control network.

@vldm vldm changed the title WIP: Rpc Rpc endpoints Jul 11, 2017
}
}

/// Shared part of context, used to take some values from the `Node` `State`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...of the context, ... from the Nodes's State'...

}

impl SharedNodeState {
/// create new `SharedNodeState`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creates a new SharedNodeState.

.reconnects_timeout.insert(addr, timeout)
}

/// Remove reconect timeout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes reconnect timeout and returns the previous value.

}
}

/// Return internal `SharedNodeState`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns internal SharedNodeState.

ApiSender { inner: inner }
}

/// Addr peer to peer list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a peer to the peers list.

.handler
let b = self.reactor
.borrow();
let rlock = b.handler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be written without additional b variable?

}
}
/// Return list of connected sockets
pub fn in_connections(&self) -> Vec<SocketAddr> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion incoming_connections is more clear name

}

impl SystemApi {
/// Create new `SystemApi`, from `ApiContext`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creates a new SystemApi, from ApiContext.

id: u16,
}

/// `DTO` used to transfer information about node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DTO is used transfer information about node.

}

impl NodeInfo {
/// Create new `NodeInfo`, from services list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creates a new NodeInfo from the services list.

@defuz defuz merged commit e7af45d into exonum:master Jul 12, 2017
@defuz defuz deleted the rpc_pool branch July 12, 2017 20:41
vldm pushed a commit that referenced this pull request Jul 13, 2017
Rpc endpoints

Former-commit-id: 85d8d41ada4987c2384a99a1f3db854a138ed07c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants