WIP: Revert time intependent consensus #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj8yfo
approved these changes
Apr 11, 2017
|
Icebox it for future tests |
|
@defuz, so, we came to understanding so far that we don't need to revert time handling to initial state, because the issue with empty blocks on multiple (6-8) nodes is easily handled with status_timeout set to a lower value (5 -> 3 sec e.g.). And the performance of 4 nodes shows similar values to the performance of reverted version, though 3 times lower than that, achieved quite before. |
defuz
changed the title
|
Can we close this pr? @defuz @gisochre |
|
I agree that this should be closed: because of the conflicts it would be easier to implement it from the scratch (if we ever need this). |
|
@defuz should we close this as too far behind? |
|
Closed as outdated |
stanislav-tkach
pushed a commit
to stanislav-tkach/exonum
that referenced
this pull request
Feb 17, 2018
Added new end-point for outputting wallet(s) info
stanislav-tkach
pushed a commit
to stanislav-tkach/exonum
that referenced
this pull request
Apr 4, 2018
Improve source and wallets
stanislav-tkach
added a commit
to stanislav-tkach/exonum
that referenced
this pull request
Apr 23, 2018
Move tests to ./tests
pavel-mukhanov
pushed a commit
to pavel-mukhanov/exonum
that referenced
this pull request
Apr 5, 2019
New identifiers pool implementation [ECR-2807]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #6 pull request because of degrading performance. In order to preserve #22, some changes are manual and not pure revert-commit.