Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TransactionInfo public #537

Merged

Conversation

alekseysidorov
Copy link
Contributor

@alekseysidorov alekseysidorov commented Mar 5, 2018

This enum is useful for testkit and other purposes.

ozkriff
ozkriff previously approved these changes Mar 5, 2018
aleksuss
aleksuss previously approved these changes Mar 5, 2018
ozkriff
ozkriff previously approved these changes Mar 5, 2018
Unknown,
InPool { content: JsonValue },
/// Transaction in the memory pool but not yet committed to the blockchain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Transaction is in the memory pool

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus "...pool, but not...".

@alekseysidorov alekseysidorov dismissed stale reviews from ozkriff and aleksuss via f881fdd March 5, 2018 15:13
@stanislav-tkach stanislav-tkach merged commit a09f785 into exonum:master Mar 5, 2018
@alekseysidorov alekseysidorov deleted the hotfix-transaction-info-public branch March 6, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants