Improved log format in blockchain_explorer/helpers.rs

[dj8yfo]

No description provided.

[dj8yfo]

If EXONUM_SRC_PATH env variable is false or not set:

[1493816662 : 482] - [ TRACE ] - exonum::events::network - Try to reconnect with delay 1000
[1493816662 : 482] - [ TRACE ] - exonum::events::network - 127.0.0.1:5400: Establish connection with 127.0.0.1:5402, id: 130
[1493816662 : 482] - [ TRACE ] - exonum::events::network - 127.0.0.1:5400: Add reconnect timeout to=127.0.0.1:5402, delay=2000
[1493816662 : 482] - [ TRACE ] - exonum::events::network - Try to reconnect with delay 1000
[1493816662 : 482] - [ TRACE ] - exonum::events::network - 127.0.0.1:5400: Establish connection with 127.0.0.1:5403, id: 131
[1493816662 : 482] - [ TRACE ] - exonum::events::network - 127.0.0.1:5400: Add reconnect timeout to=127.0.0.1:5403, delay=2000
[1493816662 : 482] - [ TRACE ] - exonum::events::network - 127.0.0.1:5400: outgoing connection with addr 127.0.0.1:5401 closed

else:

[1493816722 : 726] - [ TRACE ] - exonum::events::network:/Users/sysmanj/Exonum/exonum-core/exonum/src/events/network.rs:266 - Try to reconnect with delay 1000
[1493816722 : 726] - [ TRACE ] - exonum::events::network:/Users/sysmanj/Exonum/exonum-core/exonum/src/events/network.rs:248 - 127.0.0.1:5400: Establish connec
tion with 127.0.0.1:5403, id: 130
[1493816722 : 726] - [ TRACE ] - exonum::events::network:/Users/sysmanj/Exonum/exonum-core/exonum/src/events/network.rs:400 - 127.0.0.1:5400: Add reconnect ti
meout to=127.0.0.1:5403, delay=2000
[1493816722 : 727] - [ TRACE ] - exonum::events::network:/Users/sysmanj/Exonum/exonum-core/exonum/src/events/network.rs:170 - 127.0.0.1:5400: outgoing connect
ion with addr 127.0.0.1:5401 closed
[1493816722 : 727] - [ TRACE ] - exonum::events::network:/Users/sysmanj/Exonum/exonum-core/exonum/src/events/network.rs:170 - 127.0.0.1:5400: outgoing connect
ion with addr 127.0.0.1:5402 closed

[alekseysidorov]

EXONUM_SRC_PATH is not intuitive, i think the better name is EXONUM_LOG_VERBOSE.

[dj8yfo]

@alekseysidorov maybe not EXONUM_LOG_VERBOSE, but LOG_VERBOSE_SRC_PATH?
because technically the modules aren't restricted to exonum ones only.

[dj8yfo]

LOG_VERBOSE_SRC_FILE_LINE

[alekseysidorov]

In my opinion variables with SRC are associated with the directory with source codes.

[dj8yfo]

@alekseysidorov yep. And those are referenced in each log, if you set the variable to true.

[stanislav-tkach]

let verbose_src_path = match env::var("LOG_VERBOSE_SRC_FILE_LINE") {
    Ok(val) => val.parse::<bool>().unwrap_or(false),
    Err(_) => false,
};

Probably would be better.

[stanislav-tkach]

Perhaps, we will need some "time utils" for such things...

[alekseysidorov]

May be just use chrono crate and format time with rfc2822?

[vldm]

LGTM, but maybe move format closure into static function? And I better prefer RUST_VERBOSE_PATH name.

[alekseysidorov]

Oleg explained me some details, I was not right.
But can we use the slog crate instead of this helper in our applications?

[vldm]

LGTM