Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renew JWT token to avoid its expiration - EXO-65633 #74

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

ahamdi
Copy link
Member

@ahamdi ahamdi commented Aug 2, 2023

Every one hour, the MS Office connector fails to connect to outlook agenda to retrieve events. This is because the token expires and is not renewed as expected due to a technical limitation on the MSAL.js as detailed in AzureAD/microsoft-authentication-library-for-js#4206
The current fix forces the renewal of the token on each usage of the MSAD.js

@ahamdi ahamdi changed the base branch from develop to feature/maintenance August 2, 2023 12:24
@ahamdi ahamdi self-assigned this Aug 2, 2023
@rdenarie
Copy link
Member

rdenarie commented Aug 2, 2023

Every one hjour,

should be "Every day"

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@exo-swf exo-swf added the partialCIBuild Perform Partial CI Build label Aug 2, 2023
@ahamdi ahamdi requested review from Jihed525 and removed request for Julien-Dubois-eXo August 2, 2023 12:49
@ahamdi
Copy link
Member Author

ahamdi commented Aug 2, 2023

Every one hjour,

should be "Every day"

@rdenarie Unfortunately the lifetime of the token is one hour and it should be renewed with a refresh token, but this is not the case because of the bug described in the link I shared

@rdenarie
Copy link
Member

rdenarie commented Aug 2, 2023

Ok, so the pb was just the typo.
it should be 'Every hour', but you fixed it :)

@ahamdi ahamdi merged commit 763e383 into feature/maintenance Aug 2, 2023
8 checks passed
@ahamdi ahamdi deleted the fix/EXO-65633 branch August 2, 2023 12:56
ahamdi added a commit that referenced this pull request Aug 3, 2023
Every one hour, the MS Office connector fails to connect to outlook agenda to retrieve events. This is because the token expires and is not renewed as expected due to a technical limitation on the MSAL.js as detailed in AzureAD/microsoft-authentication-library-for-js#4206
The current fix forces the renewal of the token on each usage of the MSAD.js
ahamdi added a commit that referenced this pull request Aug 3, 2023
Every one hour, the MS Office connector fails to connect to outlook agenda to retrieve events. This is because the token expires and is not renewed as expected due to a technical limitation on the MSAL.js as detailed in AzureAD/microsoft-authentication-library-for-js#4206
The current fix forces the renewal of the token on each usage of the MSAD.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants