Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube: calico/docker version #125

Merged
merged 1 commit into from
Mar 29, 2019
Merged

kube: calico/docker version #125

merged 1 commit into from
Mar 29, 2019

Conversation

greut
Copy link
Contributor

@greut greut commented Mar 27, 2019

more flags and calico 3.6 support.

% exo lab kube create min1kube --debug --calico-version 3.4 --docker-version 18.06 --version 1.12.7
% exo lab kube list  
|   NAME   |   IP ADDRESS    |  SIZE  | VERSION | CALICO | DOCKER |  STATE  |
|----------|-----------------|--------|---------|--------|--------|---------|
| min1kube | 159.100.251.200 | Medium | 1.12.7  | 3.4    | 18.06  | Running |

@greut greut added the enhancement New feature or request label Mar 27, 2019
kube: calico/docker version
1a6987f 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
pierre-emmanuelJ
pierre-emmanuelJ approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@pierre-emmanuelJ pierre-emmanuelJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

falzm
falzm approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@falzm falzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@greut
Copy link
Contributor Author

greut commented Mar 29, 2019

The downside is that you might hit version conflicts with kubernetes-cni if you pick old versions, e.g. 1.13.3 instead 1.13.5. Adding it seems overkill.

@greut greut merged this pull request into fix/122 Mar 29, 2019
@greut greut deleted the feat/125 branch March 29, 2019 12:18
greut added a commit that referenced this pull request Mar 29, 2019
@greut
kube: calico/docker version (#125)
4425352 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falzm falzm falzm approved these changes

@pierre-emmanuelJ pierre-emmanuelJ pierre-emmanuelJ approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greut @falzm @pierre-emmanuelJ