Print SOS link when adding canned public ACL #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an overwhelming majority of cases, users setting ACLs to --public-read or --public-read-write will want to share the link to that ressource via HTTP. This saves the users a couple of clicks by printing the link to the file they just uploaded to stdout. No other canned ACLs are impacted.
chrisglass
force-pushed
the
feat/print-link-after-public-acl-set
branch
from
ecd4d4a
to
d15b652
Compare
Users might want their output quiet, let's respect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an overwhelming majority of cases, users setting ACLs to
--public-read or --public-read-write will want to share the link to that
ressource via HTTP.
This saves the users a couple of clicks by printing the link to the file
they just uploaded to stdout.
No other canned ACLs are impacted.
Example run: