Add CAA record #44
Merged
Add CAA record #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@epitech.eu>
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@epitech.eu>
|
A small entry in the changelog would be greatly appreciated |
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@epitech.eu>
ghost
approved these changes
Nov 2, 2018
ghost
reviewed
Nov 2, 2018
Co-Authored-By: pierre-emmanuelJ <pierre-emmanuel.jacquier@epitech.eu>
greut
reviewed
Nov 5, 2018
| @@ -56,7 +56,7 @@ func init() { | |||
| dnsAddCmd.AddCommand(dnsACmd) | |||
| dnsACmd.Flags().StringP("name", "n", "", "Leave this blank to create a record for <domain name>, You may use the '*' wildcard here.") | |||
| dnsACmd.Flags().StringP("address", "a", "", "Example: 127.0.0.1") | |||
| dnsACmd.Flags().IntP("ttl", "t", 3600, "The time in second to leave (refresh rate) of the record.") | |||
| dnsACmd.Flags().IntP("ttl", "t", 3600, "The time in seconds to live (refresh rate) of the record.") | |||
% exo dns add CAA yoanyoanyoan.io --tag issue,letsencrypt.org
Record "CAA" was created successfully to "yoanyoanyoan.io"
% exo dns show yoanyoanyoan.io CAA
|
greut
reviewed
Nov 5, 2018
| copy(types, args[1:]) | ||
| } else { | ||
| types = append(types, "") | ||
| types = []string{""} | ||
| } |
There was a problem hiding this comment.
As the dst was empty, nothing was copied.
Copy returns the number of elements copied, which will be the minimum of
len(src)andlen(dst).
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@epitech.eu>
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
|
(rebased) |
mcorbin
reviewed
Nov 6, 2018
| What is a flag? <https://tools.ietf.org/html/rfc6844#section-3> | ||
| `, | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| if len(args) < 1 { |
There was a problem hiding this comment.
It's not mandatory a the moment, because in other exo cmd it's like that for non fixed parameters and fixed parameters. So maybe another PR to refacto that. thank you
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@epitech.eu>
greut
reviewed
Nov 8, 2018
| @@ -4,6 +4,7 @@ | |||
| - feature new API call updateVmNicIp call | |||
| - feature sos download has a progress bar | |||
| - feature sos listings `--short` | |||
| - feature dns CAA record | |||
There was a problem hiding this comment.
I'd rebase and put that into 1.0.4
greut
pushed a commit
that referenced
this pull request
Nov 8, 2018
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #42