Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract build-metrics-reporter from build-metrics-reporters #26

Merged
merged 2 commits into from
Sep 24, 2018

Conversation

giorgio-v
Copy link
Contributor

This PR proposes the extraction of the case statement into a multimethod in order to:

  • Simplify build-metrics-reporters
  • Make the logic pluggable

We extract this multimethod in order to:
- Simplify build-metrics-reporters
- Make the logic pluggable
@greut
Copy link
Contributor

greut commented Sep 5, 2018

This looks promising, I'll test it.

Copy link
Contributor

@greut greut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pyr pyr merged commit a16845e into exoscale:master Sep 24, 2018
@pyr
Copy link
Contributor

pyr commented Sep 24, 2018

Thanks @giorgio-v!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants