Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the reporter a singleton #36

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Make the reporter a singleton #36

merged 2 commits into from
Jan 9, 2020

Conversation

mcorbin
Copy link
Contributor

@mcorbin mcorbin commented Dec 23, 2019

This commit moves the current reporter code in spootnik.reporter.impl.
In spootnik.reporter a singleton for the reporter and some functions
to initialize/use it are added.

This commit moves the current reporter code in spootnik.reporter.impl.
In spootnik.reporter a singleton for the reporter and some functions
to initialize/use it are added.
Copy link
Member

@bcachet bcachet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed we have this approach in almost all our projects that use Reporter.
Thanks to noticing it and improving it

@mcorbin mcorbin merged commit 890be26 into master Jan 9, 2020
@mcorbin mcorbin deleted the feat/singleton-reporter branch January 9, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants