sentry: log error on raven/capture! failure #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `raven/capture!` is failing we do not log anything We keep current error logging with the sentry-id (useful to link Kibana logs with Sentry)
zyegfryed
reviewed
Jun 22, 2022
| (error e (str "captured exception as sentry event: " event-id)))) | ||
| (d/catch (fn [e'] | ||
| (error e "Failed to capture exception" {:tags tags :capture-exception e'}) | ||
| (capture! this e')))) |
There was a problem hiding this comment.
If I understand correctly, in case of an error, we are going to log the previous error e and capture the raven error failure e' – i.e. in raven, right?
There was a problem hiding this comment.
Exactly, instead of throwing from reporter/capture! and relying on calling service error handling to capture it
There was a problem hiding this comment.
There is no change we'll end up on an infinite loop there?
Shall we call raven/capture! instead?
There was a problem hiding this comment.
We are calling capture! on the raven exception that we should be able to capture (and experience show we are)
There was a problem hiding this comment.
@arnaudgeiser I don't think we'll do b/c e' does not capture e in its context
jeremyvdw
approved these changes
Jun 22, 2022
zyegfryed
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
raven/capture!is failing we do not log anythingWe keep current error logging with the sentry-id (useful to link Kibana logs with Sentry)