Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

366 add user guide surrogates #370

Merged
merged 19 commits into from
Mar 13, 2024
Merged

366 add user guide surrogates #370

merged 19 commits into from
Mar 13, 2024

Conversation

niklaswulkow
Copy link
Collaborator

Dominik's and Niklas' docu of surrogate models in bofire

@niklaswulkow niklaswulkow linked an issue Mar 13, 2024 that may be closed by this pull request
@R-M-Lee R-M-Lee self-assigned this Mar 13, 2024
Copy link
Contributor

@R-M-Lee R-M-Lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

Please add a line to mkdocs.yaml here to make this new page show up in the docs. I would put this under package architecture so you can just copy the bit used for Data Models vs Functional Components

docs/userguide_surrogates.md Outdated Show resolved Hide resolved
docs/userguide_surrogates.md Outdated Show resolved Hide resolved
docs/userguide_surrogates.md Show resolved Hide resolved
docs/userguide_surrogates.md Show resolved Hide resolved
docs/userguide_surrogates.md Show resolved Hide resolved
docs/userguide_surrogates.md Outdated Show resolved Hide resolved
docs/userguide_surrogates.md Outdated Show resolved Hide resolved
docs/userguide_surrogates.md Show resolved Hide resolved
docs/userguide_surrogates.md Outdated Show resolved Hide resolved
docs/userguide_surrogates.md Outdated Show resolved Hide resolved
@R-M-Lee R-M-Lee removed their assignment Mar 13, 2024
@R-M-Lee
Copy link
Contributor

R-M-Lee commented Mar 13, 2024

@dlinzner-bcs I just reviewed this

@niklaswulkow
Copy link
Collaborator Author

Thank you, the line in mkdocs.yaml is now added.

Great stuff!

Please add a line to mkdocs.yaml here to make this new page show up in the docs. I would put this under package architecture so you can just copy the bit used for Data Models vs Functional Components

@R-M-Lee
Copy link
Contributor

R-M-Lee commented Mar 13, 2024

ok. If you are happy with my suggestions you can just click on 'commit suggestion' at each appropriate block (you don't have to take my suggestion of course).

Then we can merge

niklaswulkow and others added 7 commits March 13, 2024 13:27
Co-authored-by: Robert Lee <84771576+R-M-Lee@users.noreply.github.com>
Co-authored-by: Robert Lee <84771576+R-M-Lee@users.noreply.github.com>
Co-authored-by: Robert Lee <84771576+R-M-Lee@users.noreply.github.com>
Co-authored-by: Robert Lee <84771576+R-M-Lee@users.noreply.github.com>
Co-authored-by: Robert Lee <84771576+R-M-Lee@users.noreply.github.com>
Co-authored-by: Robert Lee <84771576+R-M-Lee@users.noreply.github.com>
Co-authored-by: Robert Lee <84771576+R-M-Lee@users.noreply.github.com>
@R-M-Lee R-M-Lee merged commit 887b3c4 into main Mar 13, 2024
10 checks passed
@R-M-Lee R-M-Lee deleted the 366-add-user-guide-surrogates branch March 13, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add User Guide: Surrogates
3 participants