Skip to content

Commit

Permalink
refactor(team.rb): yet some more codeclimate issue
Browse files Browse the repository at this point in the history
Solved a few more codeclimate issues
  • Loading branch information
darshil0193 committed Nov 5, 2017
1 parent 6e1ceff commit a72388f
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions app/models/team.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def responses

# Delete the given team
def delete
TeamsUser.where(team_id: self.id).each(&:destroy)
TeamsUser.where(team_id: self.id).find_each(&:destroy)
node = TeamNode.find_by(node_object_id: self.id)
node.destroy if node
self.destroy
Expand Down Expand Up @@ -127,15 +127,15 @@ def self.randomize_all_by_parent(parent, team_type, min_team_size)

def self.create_team_from_single_users(min_team_size, parent, team_type, users)
num_of_teams = users.length.fdiv(min_team_size).ceil
nextTeamMemberIndex = 0
next_team_member_index = 0
for i in (1..num_of_teams).to_a
team = Object.const_get(team_type + 'Team').create(name: "Team" + i.to_s, parent_id: parent.id)
TeamNode.create(parent_id: parent.id, node_object_id: team.id)
min_team_size.times do
break if nextTeamMemberIndex >= users.length
user = users[nextTeamMemberIndex]
break if next_team_member_index >= users.length
user = users[next_team_member_index]
team.add_member(user, parent.id)
nextTeamMemberIndex += 1
next_team_member_index += 1
end
end
end
Expand All @@ -144,7 +144,7 @@ def self.assign_single_users_to_teams(min_team_size, parent, teams, users)
teams.each do |team|
curr_team_size = Team.size(team.id)
member_num_difference = min_team_size - curr_team_size
while (member_num_difference > 0)
while member_num_difference > 0
team.add_member(users.first, parent.id)
users.delete(users.first)
member_num_difference -= 1
Expand Down

0 comments on commit a72388f

Please sign in to comment.