Project E1936 doesn't save specialized rubrics

[efg]

We merged project E1936, Specialized Rubrics (#1444 ) but had trouble with it. This project makes it possible to specify specialized rubrics for each topic type, but not save these rubrics. That is, if you go to the Topics tab and select a specialized rubric, say Mozilla test (http://localhost:3000/questionnaires/view?id=647) for a particular topic, and hit the Save button at the bottom of the page, when the page redisplays, the dropdown for the topic will still say the rubric that was used before you tried to change the rubric to Mozilla test. That is to say, after changing rubrics for particular topics, there is no way to save them.

We poked around and found that (1) after an attempt to change a rubric, the pre-existing assignment_questionnaires entry was deleted rather than changed. A new entry had been created to take its place. Then we used a sql command to change the topic_id field of one of the assignment_questionnaires entries. Then we visited the topics tab again, all of the previous assignments_questionnaires entries were gone, and the new assignments_questionnaires entries all specified the rubric that is listed on the Rubrics tab.

mysql> select * from assignment_questionnaires where assignment_id = 982 and topic_id is not null;
+-------+---------------+------------------+---------+--------------------+----------------------+---------------+----------+----------+
| id    | assignment_id | questionnaire_id | user_id | notification_limit | questionnaire_weight | used_in_round | dropdown | topic_id |
+-------+---------------+------------------+---------+--------------------+----------------------+---------------+----------+----------+
| 47944 |           982 |              648 |    NULL |                 15 |                  100 |             1 |        1 |     4725 |
| 47945 |           982 |              647 |    NULL |                 15 |                  100 |             1 |        1 |     4726 |
| 47946 |           982 |              649 |    NULL |                 15 |                    0 |             2 |        1 |     4725 |
| 47947 |           982 |              649 |    NULL |                 15 |                    0 |             2 |        1 |     4726 |
| 47948 |           982 |               22 |    NULL |                 15 |                    0 |          NULL |        1 |     4725 |
| 47949 |           982 |               22 |    NULL |                 15 |                    0 |          NULL |        1 |     4726 |
+-------+---------------+------------------+---------+--------------------+----------------------+---------------+----------+----------+
6 rows in set (0.00 sec)

mysql> select * from assignment_questionnaires where assignment_id = 982 and topic_id is not null;
+-------+---------------+------------------+---------+--------------------+----------------------+---------------+----------+----------+
| id    | assignment_id | questionnaire_id | user_id | notification_limit | questionnaire_weight | used_in_round | dropdown | topic_id |
+-------+---------------+------------------+---------+--------------------+----------------------+---------------+----------+----------+
| 47950 |           982 |              648 |    NULL |                 15 |                  100 |             1 |        1 |     4725 |
| 47951 |           982 |              648 |    NULL |                 15 |                  100 |             1 |        1 |     4726 |
| 47952 |           982 |              649 |    NULL |                 15 |                    0 |             2 |        1 |     4725 |
| 47953 |           982 |              649 |    NULL |                 15 |                    0 |             2 |        1 |     4726 |
| 47954 |           982 |               22 |    NULL |                 15 |                    0 |          NULL |        1 |     4725 |
| 47955 |           982 |               22 |    NULL |                 15 |                    0 |          NULL |        1 |     4726 |
+-------+---------------+------------------+---------+--------------------+----------------------+---------------+----------+----------+
6 rows in set (0.00 sec)

So regardless of what changes are made on the Topics tab, the rubrics specified on the Rubrics tab are used for all topics.

[Saurabh110]

Fixed by Pull Request #1444