Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying assignment + changing submission directory causes submission directory to be renamed! #37

Closed
efg opened this issue Dec 4, 2010 · 6 comments

Comments

@efg
Copy link
Member

efg commented Dec 4, 2010

Yesterday, I copied my "Battleship code review" assignment and renamed the new copy "Scavenger Hunt code review". I changed the submission directory from [efg]/csc216/f10/battleship to [efg]/csc216/f10/scavenger_hunt. To my surprise, this RENAMED the battleship directory to scavenger_hunt, with the consequence that all the submissions went in the same directory with submissions from the other assignment!

I have resolved the problem by moving the files to the correct directories, but the bug remains: When an assignment is copied and the submission directory path is edited, it should result in a NEW path being associated with the copied assignment, and should NOT rename the directory, which has the effect of making two assignments share a submission directory. If the directory name is changed in a situation not pursuant to copying an assignment, it would be reasonable to ASK the user whether the name of the existing submission directory should be changed, or a new directory created.

@efg
Copy link
Member Author

efg commented Jan 8, 2011

This bug is still extant! I encountered it a minute ago. Fortunately, I knew to check for it. Another instructor wouldn't.

It needs to be fixed right away.

@efg
Copy link
Member Author

efg commented Apr 20, 2011

Mauricio and I checked this morning, and found that this bug no longer existed.

@efg efg closed this as completed Apr 20, 2011
@efg efg reopened this Oct 6, 2011
@efg
Copy link
Member Author

efg commented Oct 6, 2011

But alas, the bug surfaced again! It occurred when I created the Project 1 assignment for this year's CSC/ECE 517 by copying last year's Project 1. I specified a submission directory csc517/f11/backchannel, which I did by editing the submission-directory field. What happened was that the f10/backchannel directory got renamed to f11/backchannel.

This may be a regression, but it needs to be fixed.

@efg
Copy link
Member Author

efg commented Feb 1, 2012

It happened again! When Vaibhav created Jennifer Kidd's TLED 301 assignment for Spring 2012a, the Fall 2011a files ended up in the Spring 2011a directory. (I just moved them out of it to avoid the consequences.) This needs to be fixed! Otherwise, any instructor copying an assignment will find that the current semester's submissions get mixed up with the previous semester's!

@efg
Copy link
Member Author

efg commented Mar 23, 2012

It happened yet again to the UCF instructor Jessica! I fixed the directory structure this morning.

@efg
Copy link
Member Author

efg commented Jun 16, 2017

We think this bug has been removed, but we could sure use a test verifying that it has not resurfaced!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants