Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oss idea for 2016] self-review #644

Closed
yangsong8 opened this issue Dec 28, 2015 · 3 comments
Closed

[oss idea for 2016] self-review #644

yangsong8 opened this issue Dec 28, 2015 · 3 comments

Comments

@yangsong8
Copy link
Contributor

We had this feature once (E726 which was very old). The design was done in a wrong way:

  • The self-review_questionnaire_id is a column in assignments table, instead it should be a record in assignment_questionnaires table
  • The partial "self_review" is in /view/submitted_content folder, it would be better if it is in /view/self_review folder.
  • We need to do further design and figure out a clean way for self-review and peer-review to use a same rubric.
@yangsong8
Copy link
Contributor Author

More updates about this issue. The self_review_questionnaire_id has been removed from assignments table, please see this commit f78d6a5. The self_review partial has also been removed, please see this commit b6cf72d.

@yangsong8
Copy link
Contributor Author

One thought about this issue, we can add a boolean "self_review_allowed" to assignments table. We assume that self-review should use same rubric as peer-review.

@yangsong8
Copy link
Contributor Author

yangsong8 commented May 2, 2016

This is done in E1600 (Self-review feature) and this project has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant