E1808 Refactor review_mapping_controller.rb #1146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create E1808-Pull Request
refactoring response_report
ferryxo
reviewed
Mar 19, 2018
| @@ -358,71 +358,8 @@ def response_report | |||
| # to treat all assignments as team assignments | |||
| @type = params.key?(:report) ? params[:report][:type] : "ReviewResponseMap" | |||
| summary_ws_url = WEBSERVICE_CONFIG["summary_webservice_url"] | |||
There was a problem hiding this comment.
you can put this in the SummaryReport class, so you don't have to pass it as a parameter.
move summary_ws_url to factory
…ndividual assignment
…t_refactor_with_helper Merging the refcatored automatic review mapping controller with the master
Restoring back to the previous version
Automatic Review Mapping && Testing
|
not ready to merge, causing a lot of bugs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.