Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E1959.Intelligent copying of assignments without topics (Issue #1341) #1524

Merged
merged 20 commits into from Mar 7, 2021
Merged

E1959.Intelligent copying of assignments without topics (Issue #1341) #1524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
868ca44
Identified the code requiring modification
VishnusRepo Oct 17, 2019
d6a924d
Additions for confirming copying topics
VishnusRepo Oct 21, 2019
8b34233
Fixed errors
VishnusRepo Oct 21, 2019
688977f
Topics created only when YES is selected and modified the format of t…
subhasekhar Oct 21, 2019
dc6ccea
Added a flash message after the assignment is successfully copied
subhasekhar Oct 22, 2019
1d96b42
Modified the test case for assignment_form.rb
subhasekhar Oct 26, 2019
c01d689
Modified the tests for the assignments_controller.rb
subhasekhar Oct 27, 2019
33f0632
Removed trailing spaces for rubocop
Oct 27, 2019
47a83a4
Implementation of Issues 1 & 2
VishnusRepo Oct 27, 2019
84279f4
Minor changes in the checktopicscopy.html
subhasekhar Oct 27, 2019
c2bbf95
Modifications to test cases for assignment controller and model
rohanpillai20 Oct 28, 2019
9391b58
Changes made to pass codeclimate tests
rohanpillai20 Oct 28, 2019
fb1a589
Modifications to assignment_form_spec and changes to pass codeclimate
rohanpillai20 Oct 28, 2019
431c1cc
Added testcases for controllers/assignments_controller.rb and models/…
rohanpillai20 Nov 3, 2019
a7f56ef
Changes recommended by code climate
rohanpillai20 Nov 5, 2019
f9f7648
Changes in assignment_form based on code climate recommendation
rohanpillai20 Nov 5, 2019
5d3b52c
CodeClimate changes in assignment_form.rb
rohanpillai20 Nov 5, 2019
3eebcb9
CodeClimate changes in assignment_form.rb
rohanpillai20 Nov 5, 2019
cfc54c3
CodeClimate tab changes in assignment_form.rb
rohanpillai20 Nov 5, 2019
f6c084e
Merge branch 'master' into master
Saurabh110 Mar 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions Gemfile.lock
View file
Open in desktop
Expand Up @@ -152,7 +152,7 @@ GEM
term-ansicolor (~> 1.3)
thor (~> 0.19.4)
tins (~> 1.6)
crass (1.0.4)
crass (1.0.5)
daemons (1.2.6)
database_cleaner (1.6.2)
delayed_job (4.1.4)
Expand Down Expand Up @@ -264,7 +264,7 @@ GEM
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
ruby_dep (~> 1.2)
loofah (2.2.3)
loofah (2.3.1)
crass (~> 1.0.2)
nokogiri (>= 1.5.9)
lumberjack (1.0.12)
Expand All @@ -276,7 +276,7 @@ GEM
mime-types (2.99.3)
mini_mime (1.0.1)
mini_portile2 (2.4.0)
minitest (5.11.3)
minitest (5.12.2)
morpher (0.2.6)
abstract_type (~> 0.0.7)
adamantium (~> 0.2.0)
Expand Down Expand Up @@ -390,8 +390,8 @@ GEM
activesupport (>= 4.2.0, < 5.0)
nokogiri (~> 1.6)
rails-deprecated_sanitizer (>= 1.0.1)
rails-html-sanitizer (1.0.4)
loofah (~> 2.2, >= 2.2.2)
rails-html-sanitizer (1.3.0)
loofah (~> 2.3)
rails4-autocomplete (1.1.1)
rails (>= 3.0)
railties (4.2.11.1)
Expand All @@ -400,7 +400,7 @@ GEM
rake (>= 0.8.7)
thor (>= 0.18.1, < 2.0)
rainbow (3.0.0)
rake (12.3.2)
rake (13.0.0)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the Gems versions are changed, it might affect the other parts of the system. Could to try keeping the same version?

rb-fsevent (0.10.2)
rb-inotify (0.9.10)
ffi (>= 0.5.0, < 2)
Expand Down