Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2003, Refactor Assessment 360 Controller #1691

Closed
wants to merge 20 commits into from
Closed

E2003, Refactor Assessment 360 Controller #1691

wants to merge 20 commits into from

Commits on Mar 19, 2020

  1. fixed course student grade summary

    @ramyananth
    ramyananth committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    ba12c91 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2020

  1. refactored similar blocks, reduced cyclomatic and perceived complexit… 

    …y of course_student_grade_summary, reduced cyclomatic complexity of all_students_all_reviews
    @ramyananth
    ramyananth committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    829d37f View commit details
    Browse the repository at this point in the history

  2. refactored similar blocks, reduced cyclomatic and perceived complexit… 

    …y of course_student_grade_summary, reduced cyclomatic complexity of all_students_all_reviews
    @ramyananth
    ramyananth committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    b47c529 View commit details
    Browse the repository at this point in the history

  3. added space after comma, removed extra space

    @ramyananth
    ramyananth committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    dd5994b View commit details
    Browse the repository at this point in the history

  4. removed trailing white spaces

    @ramyananth
    ramyananth committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    c7d3b67 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. using guard clause instead of wrapping code

    @ramyananth
    ramyananth committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    48ecd75 View commit details
    Browse the repository at this point in the history

  2. fixed non-local exit from iterator

    @ramyananth
    ramyananth committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    a732509 View commit details
    Browse the repository at this point in the history

  3. changed function names to more meaningful ones

    @ramyananth
    ramyananth committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    3dbf320 View commit details
    Browse the repository at this point in the history

  4. rename review_info_per_stu to avg_review_calc_per_stu

    @ramyananth
    ramyananth committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    326a7ae View commit details
    Browse the repository at this point in the history

  5. reduced number of parameters being passed

    @ramyananth
    ramyananth committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    1df1e0e View commit details
    Browse the repository at this point in the history

  6. added comments for all functions - easier understanding_

    @ramyananth
    ramyananth committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    4dc72f3 View commit details
    Browse the repository at this point in the history

  7. removed trailing whitespaces from comments

    @ramyananth
    ramyananth committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    192a957 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Renamed populate_hash_function,fixed the overal_review_count_hash

    @ushvarma
    ushvarma committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    2b00478 View commit details
    Browse the repository at this point in the history

  2. Replace dig function with a hash check

    @ushvarma
    ushvarma committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    a4345fa View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Delete Gemfile.lock

    @ramyananth
    ramyananth committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    56ecccc View commit details
    Browse the repository at this point in the history

  2. modify to not push gemfile.lock

    @ramyananth
    ramyananth committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    0527b89 View commit details
    Browse the repository at this point in the history

  3. push gemfile.lock

    @ramyananth
    ramyananth committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    c05bd4c View commit details
    Browse the repository at this point in the history

  4. uncommit to avoid bundle failure

    @ramyananth
    ramyananth committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    6273bb2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/ramyananth/expertiza

    @ramyananth
    ramyananth committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    49d37a4 View commit details
    Browse the repository at this point in the history

  6. removed empty line

    @ramyananth
    ramyananth committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    a6044f8 View commit details
    Browse the repository at this point in the history