Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2055. Write unit tests for student_task.rb #1810 #1811

Merged
merged 20 commits into from
Jan 10, 2021
Merged

E2055. Write unit tests for student_task.rb #1810 #1811

merged 20 commits into from
Jan 10, 2021

Conversation

LukeMccon
Copy link
Contributor

@LukeMccon LukeMccon commented Oct 14, 2020

Implementation of a few of the tests
These changes are not complete this is the first deadline submission, do not merge
Reviewer: Sanket Pai (sgpai2@ncsu.edu)

Wiki / Documentation link https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2020_-_E2055_write_unit_tests_for_student_task.rb

@expertiza-bot
Copy link
Contributor

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

1 Warning
1 ⚠️ Using create in unit tests or integration tests may be overkill. Try to use build or double instead.

Generated by expertiza-bot

@coveralls
Copy link

coveralls commented Oct 14, 2020

Coverage Status

Coverage increased (+0.4%) to 43.342% when pulling 132f09c on johnbumgardner:beta into 69a8436 on expertiza:beta.

@expertiza-travisci-bot
Copy link

Hey @LukeMccon,
Your changes look good to me! 🎉

@LukeMccon LukeMccon closed this Oct 20, 2020
@LukeMccon LukeMccon reopened this Oct 20, 2020
@Saurabh110 Saurabh110 merged commit 2668f74 into expertiza:beta Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants