Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grade refactoring #2029

Merged
merged 27 commits into from Aug 31, 2021
Merged

Grade refactoring #2029

merged 27 commits into from Aug 31, 2021

Conversation

johnbumgardner
Copy link
Collaborator

@johnbumgardner johnbumgardner commented Aug 28, 2021

I did manual testing

@expertiza-bot
Copy link
Contributor

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

Generated by expertiza-bot

1 similar comment
@expertiza-bot
Copy link
Contributor

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

Generated by expertiza-bot

@expertiza-bot
Copy link
Contributor

expertiza-bot commented Aug 28, 2021

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

UUID 2 Warnings
be55 ⚠️ There are one or more skipped/pending/focused test cases in your pull request. Please fix them.
2ec0 ⚠️ Using create in unit tests or integration tests may be overkill. Try to use build or double instead.

Generated by expertiza-bot

@coveralls
Copy link

Coverage Status

Coverage decreased (-19.1%) to 37.645% when pulling e44aff1 on johnbumgardner:mapping-level into fcc760a on expertiza:beta.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-19.1%) to 37.645% when pulling e44aff1 on johnbumgardner:mapping-level into fcc760a on expertiza:beta.

@coveralls
Copy link

coveralls commented Aug 28, 2021

Coverage Status

Coverage increased (+10.07%) to 66.814% when pulling a3f1a4d on johnbumgardner:mapping-level into fcc760a on expertiza:beta.

@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Aug 31, 2021

Hey @johnbumgardner,
Your changes look good to me! 🎉

Copy link
Collaborator

@nnhimes nnhimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nnhimes nnhimes merged commit c7573ce into expertiza:beta Aug 31, 2021
@nnhimes nnhimes deleted the mapping-level branch August 31, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants