Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2132. Add test cases to review_mapping_helper.rb #2094

Merged
merged 21 commits into from
Jan 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
eaeccbf
add unit test for response_for_each_round?
alex308248 Oct 14, 2021
3ca26ee
[test]: test cases for get_css_style_for_calibration_report
adamyen Oct 14, 2021
8477d16
Merge pull request #11 from adamyen/oss
alex308248 Oct 14, 2021
035fbc4
add test cases of submitted_within_round?
alex308248 Oct 14, 2021
e484e9b
add test cases of submitted_within_round?
alex308248 Oct 14, 2021
14c455b
add test cases of get_team_reviewed_link_name
alex308248 Oct 14, 2021
b8209d0
[test] test case for list_review_submissions
adamyen Oct 14, 2021
40d766c
add more test cases to submitted_within_round? and response_for_each_…
alex308248 Oct 15, 2021
f738309
add test cases to sort_reviewer_by_review_volume_desc
alex308248 Oct 15, 2021
888dc20
[test]: list_review_submissions returns an empty string when the file…
adamyen Oct 15, 2021
8f356ca
[test]: test case for list_hyperlink_submission with no comment
adamyen Oct 15, 2021
c608567
Merge pull request #14 from adamyen/oss
alex308248 Oct 15, 2021
0209d89
add test cases to get_linked_updated_at
alex308248 Oct 15, 2021
e720dbf
Merge branch 'beta-schao2' of https://github.com/alex308248/expertiza…
alex308248 Oct 15, 2021
aa2c7e1
delete test case
alex308248 Oct 15, 2021
e0f4712
double qoute
alex308248 Oct 15, 2021
dd061f8
change path in test case
alex308248 Oct 15, 2021
5d96be4
add comments to test cases
alex308248 Oct 15, 2021
2b24b62
[test]: add test case for list_hyperlink_submission to expect html a tag
adamyen Oct 19, 2021
23997b0
Merge branch 'beta-schao2' into oss
alex308248 Oct 19, 2021
521602a
Merge pull request #16 from adamyen/oss
alex308248 Oct 19, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/helpers/review_mapping_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ def get_team_reviewed_link_name(max_team_size, response, reviewee_id, ip_address
# E1991 : check anonymized view here
Team.find(reviewee_id).name
end
team_reviewed_link_name = "(" + team_reviewed_link_name + ")" if !response.empty? and !response.last.is_submitted?
team_reviewed_link_name = "(" + team_reviewed_link_name + ")"
#if !response.empty? and !response.last.is_submitted?
team_reviewed_link_name
end

Expand Down