E2120. Refactor reputation_web_service_controller.rb

[VarunVeginati]

• Removed the commented/unused code.
• Added comments for the controller.
• Renamed db_query, json_generator, and client appropriately.
• Refactored send_post_request method
• Moved passwords for private keys to db.
• Fixed spelling of 'dimention'.
• Added rspec test cases for the new methods.

[expertiza-bot]

1 Message

💬

Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon. This repository is being automatically checked for code-quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review. Also, please spend some time looking at the instructions at the top of your course project writeup. If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

UUID		3 Warnings
9643	⚠️	The should syntax is deprecated in RSpec 3. Please use expect syntax instead. Even in test descriptions, please avoid using should.
c951	⚠️	You should commit changes to the DB schema (db/schema.rb) only if you have created new DB migrations. Please double check your code. If you did not aim to change the DB, please revert the DB schema changes.
e29c	⚠️	One or more of your test expectations do not have matchers. To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please include matchers, such as comparisons (e.g., equal(expected_value)), the status change of objects (e.g., change(object, :value).by(delta)), error handlings (e.g., raise_error("message")).
ecaa	✅	There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.

Generated by expertiza-bot

[coveralls]

Coverage decreased (-18.6%) to 38.169% when pulling bd85ab3 on VarunVeginati:beta into 6ad3607 on expertiza:beta.

[coveralls]

Coverage decreased (-18.6%) to 38.169% when pulling bd85ab3 on VarunVeginati:beta into 6ad3607 on expertiza:beta.

[coveralls]

Coverage increased (+0.4%) to 57.169% when pulling f7ae401 on VarunVeginati:beta into 6ad3607 on expertiza:beta.