Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2151. Allow reviewers to bid on what to review #2150

Merged
merged 60 commits into from
Jan 27, 2022
Merged

E2151. Allow reviewers to bid on what to review #2150

merged 60 commits into from
Jan 27, 2022

Commits on Nov 19, 2021

  1. Add files and changes from prior review bid implementation

    @Aeront39
    Aeront39 committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    05399af View commit details
    Browse the repository at this point in the history

  2. modify database migrations

    @Aeront39
    Aeront39 committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    2444fb2 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Modify names of files for review bid views

    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    9de8799 View commit details
    Browse the repository at this point in the history

  2. Delete all views and partials explicitly for review_bids

    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    89a4bde View commit details
    Browse the repository at this point in the history

  3. Revert "Delete all views and partials explicitly for review_bids" 

    This reverts commit 89a4bde.
    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    35a4971 View commit details
    Browse the repository at this point in the history

  4. Create new shared partial used for table line of both reviews and top… 

    …ics in sign up
    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    4314983 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary portion of base_table_name

    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    0495b25 View commit details
    Browse the repository at this point in the history

  6. Modify views for review bidding to render as expected

    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    2097d0d View commit details
    Browse the repository at this point in the history

  7. Modify view files for review bids to render properly

    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    567a212 View commit details
    Browse the repository at this point in the history

  8. Merge https://github.com/WeiRui-Wang/expertiza into beta

    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    e92c4d0 View commit details
    Browse the repository at this point in the history

  9. Delete unnecessary view components for review bidding

    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    b670f79 View commit details
    Browse the repository at this point in the history

  10. Merge https://github.com/WeiRui-Wang/expertiza into beta

    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    534ff34 View commit details
    Browse the repository at this point in the history

  11. Fix incorrect render of partial in review_bid_table_line view

    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    03ea8fe View commit details
    Browse the repository at this point in the history

  12. Merge https://github.com/WeiRui-Wang/expertiza into beta

    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    bcf8a2e View commit details
    Browse the repository at this point in the history

  13. Update url for algorithm and test cases

    @Aeront39
    Aeront39 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    a89ad51 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Merge https://github.com/WeiRui-Wang/expertiza into beta

    @Aeront39
    Aeront39 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    e6edf75 View commit details
    Browse the repository at this point in the history

  2. Revert "Delete all views and partials explicitly for review_bids" 

    This reverts commit 89a4bde.

Modify names of files for review bid views

Delete all views and partials explicitly for review_bids

Create new shared partial used for table line of both reviews and topics in sign up

Remove unnecessary portion of base_table_name

Modify view files for review bids to render properly

Delete unnecessary view components for review bidding

Fix incorrect render of partial in review_bid_table_line view

Update url for algorithm and test cases
    @Aeront39
    Aeront39 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    81eafe4 View commit details
    Browse the repository at this point in the history

  3. Revert "Revert "Delete all views and partials explicitly for review_b… 

    …ids""

This reverts commit 81eafe4.
    @Aeront39
    Aeront39 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    6b2b37a View commit details
    Browse the repository at this point in the history

  4. Temporary modify to review bids controller to fix apparent bug, needs… 

    … further investigation
    @Aeront39
    Aeront39 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    ad0b5a8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'beta-back' into beta

    @Aeront39
    Aeront39 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    2979529 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'beta' of https://github.com/WeiRui-Wang/expertiza into … 

    …beta
    @Aeront39
    Aeront39 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    6c7c1d1 View commit details
    Browse the repository at this point in the history

  7. Add debugging when running algorithm to help figuring out

    @Aeront39
    Aeront39 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    2684c45 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Remove troublesome local variable from controller to allow reviews to… 

    … be seen
    @Aeront39
    Aeront39 committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    fd74ee5 View commit details
    Browse the repository at this point in the history

  2. Fix merge issues

    @Aeront39
    Aeront39 committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    14186da View commit details
    Browse the repository at this point in the history

  3. Revise necessity to be on a team to see reviews

    @Aeront39
    Aeront39 committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    239c521 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'beta-back' into beta

    @Aeront39
    Aeront39 committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    34803ad View commit details
    Browse the repository at this point in the history

  5. Modify beta to have same fixes implemented in beta-back

    @Aeront39
    Aeront39 committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    58cb3a9 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'beta' of https://github.com/WeiRui-Wang/expertiza into … 

    …beta

Conflicts:
	app/views/sign_up_sheet/_review_bid_table_line.html.erb
    @Aeront39
    Aeront39 committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    06fea7e View commit details
    Browse the repository at this point in the history

  7. Replace bidding debug print with proper functionality, can now create… 

    … assignments, bid on them, and assign bids.
    @Aeront39
    Aeront39 committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    4867f6c View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2021

  1. Merge branch 'expertiza:beta' into beta

    @WeiRui-Wang
    WeiRui-Wang committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    37e6770 View commit details
    Browse the repository at this point in the history

  2. Soft rollback to address reported testing issue.

    WeiRui Wang committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    ef7eb34 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/beta' into beta

    WeiRui Wang committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    73f87d3 View commit details
    Browse the repository at this point in the history

  4. Update review_bids_controller to address build issue.

    WeiRui Wang committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    011114b View commit details
    Browse the repository at this point in the history

  5. Move review bids views into sign up sheet views.

    @Aeront39
    Aeront39 committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    809f51f View commit details
    Browse the repository at this point in the history

  6. Finalized on the DRY refactoring review_bids_controller. 

    + Reviewed phase finding related logic DRYness.
+ Concluded related internal logic is no longer necessary.
    WeiRui Wang committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    283f58f View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Adding reviewer_self_topic function call to review big controller

    @aluthra37
    aluthra37 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    966ad96 View commit details
    Browse the repository at this point in the history

  2. Update review_bids_controller to address rollback issue.

    WeiRui Wang committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    8bd048a View commit details
    Browse the repository at this point in the history

  3. Update related file to address rollback issue. 

    Signed-off-by: WeiRui Wang <wnwang@ncsu.edu>
    WeiRui Wang committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    f41e549 View commit details
    Browse the repository at this point in the history

  4. Resolved a long-term syntax error.

    WeiRui Wang committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    f68ba41 View commit details
    Browse the repository at this point in the history

  5. Rollback to version before syntax patch.

    WeiRui Wang committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    efb0d82 View commit details
    Browse the repository at this point in the history

  6. Update controller to use self.topic_id method

    @aluthra37
    aluthra37 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    61fb20b View commit details
    Browse the repository at this point in the history

  7. Remove DRY violating method from review bid model

    @Aeront39
    Aeront39 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    ebf3151 View commit details
    Browse the repository at this point in the history

  8. Updating reviewer_bidding_data to use topic_id method

    @aluthra37
    aluthra37 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    73a8729 View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary 'create' method from review bids controller

    @Aeront39
    Aeront39 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    66eecf4 View commit details
    Browse the repository at this point in the history

  10. Rename confusing reviewer_id variable in review_bid model

    @Aeront39
    Aeront39 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    9b35988 View commit details
    Browse the repository at this point in the history

  11. Add proper finding of reviewer id for finding original topic

    @Aeront39
    Aeront39 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    352591d View commit details
    Browse the repository at this point in the history

  12. Change website url back to proper form

    @Aeront39
    Aeront39 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    3534090 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'beta' of https://github.com/WeiRui-Wang/expertiza into … 

    …beta
    @Aeront39
    Aeront39 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    3001803 View commit details
    Browse the repository at this point in the history

  14. Remove commented out code

    @Aeront39
    Aeront39 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    aa7cb91 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Remove unhelpful and improper test cases, remove spec test for remove… 

    …d method
    @Aeront39
    Aeront39 committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    3f743fe View commit details
    Browse the repository at this point in the history

  2. Remove requiring of rspec gem inside of tests

    @Aeront39
    Aeront39 committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    200a058 View commit details
    Browse the repository at this point in the history

  3. Re-make prior changes that were reverted, including removing unnecces… 

    …sary instance variable and supplying proper algorithm url
    @Aeront39
    Aeront39 committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    d3d97cb View commit details
    Browse the repository at this point in the history

  4. rename method to get current assignment stage

    @Aeront39
    Aeront39 committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    1c74caa View commit details
    Browse the repository at this point in the history

  5. remove DRY violating files no longer needed in review bids view

    @Aeront39
    Aeront39 committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    15bba71 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. modify details of some views to work properly

    @Aeront39
    Aeront39 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    e2a11b1 View commit details
    Browse the repository at this point in the history

  2. resolve merge conflicts for review bid controller url

    @Aeront39
    Aeront39 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    f5a18d7 View commit details
    Browse the repository at this point in the history

  3. Revise code to DRY out finding a reviewer's own topic

    @Aeront39
    Aeront39 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    6cf9356 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2021

  1. Modify others_work to work with newly renamed methods for getting the… 

    … current stage of the assignment.
    @Aeront39
    Aeront39 committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    818c4b8 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Remove calculation of unneccesary variable that led to DRY violation.

    @Aeront39
    Aeront39 committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    60fb36b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Merge branch 'beta' of https://github.com/expertiza/expertiza into pr… 

    …/2150
    @johnbumgardner
    johnbumgardner committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    e45e3d7 View commit details
    Browse the repository at this point in the history