E2150. Integrate suggestion detection algorithm

[griffinbrookshire]

Please set the title of your pull request in the following format: [Project id/Independent study/Issue fix/...]. project name, eg., E904. Integrating courses and assignments on Expertiza with Moodle

We suggest you including the below information in your pull request:

• A description of the changes proposed in the pull request.
• @mentions of the person or team responsible for reviewing proposed changes.

---

About Expertiza Bot

• If you have any questions about comments given by the expertiza-bot (example), you could create a comment in your pull request with the format /dispute [UUID1] [UUID2] (example) then the professor and TAs will be notified.
• Here is a video about how to communicate to expertiza-bot.

@divyang02 @psengo7 @srujanponnur @griffinbrookshire

Made significant refactors to the previous semesters implementation of the suggestion detection algorithm, including:

• UI Changes
• Bug Fixes
• Move hardcoded values to config file
• Removing duplicate code

[expertiza-bot]

1 Message

💬

Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon. This repository is being automatically checked for code-quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review. Also, please spend some time looking at the instructions at the top of your course project writeup. If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

UUID		3 Warnings
c951	⚠️	You should commit changes to the DB schema (db/schema.rb) only if you have created new DB migrations. Please double check your code. If you did not aim to change the DB, please revert the DB schema changes.
d699	⚠️	You changed YAML (*.yml) or example (*.yml.example) files; please double-check whether this is necessary.
0440	⚠️	One or more of your test expectations only focus on the return value not being nil, empty or not equal to 0 without testing the real value. To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please write expectations to test the real value.

UUID		1 Error
65de	💥	You are including debug code in your pull request, please remove it.

Generated by expertiza-bot

[expertiza-bot]

1 Message

💬

Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon. This repository is being automatically checked for code-quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review. Also, please spend some time looking at the instructions at the top of your course project writeup. If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

UUID		3 Warnings
c951	⚠️	You should commit changes to the DB schema (db/schema.rb) only if you have created new DB migrations. Please double check your code. If you did not aim to change the DB, please revert the DB schema changes.
d699	⚠️	You changed YAML (*.yml) or example (*.yml.example) files; please double-check whether this is necessary.
0440	⚠️	One or more of your test expectations only focus on the return value not being nil, empty or not equal to 0 without testing the real value. To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please write expectations to test the real value.

UUID		1 Error
65de	💥	You are including debug code in your pull request, please remove it.

Generated by expertiza-bot

[expertiza-travisci-bot]

Hey @griffinbrookshire,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

[griffinbrookshire]

/rerun

[expertiza-bot]

Your request has been accepted by the bot. Please wait, it can take up to 10 min to process the request.

[griffinbrookshire]

/rerun

[expertiza-bot]

Your request has been accepted by the bot. Please wait, it can take up to 10 min to process the request.