Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2205: Testing for participants_controller, versions_controller #2289

Merged
merged 71 commits into from Apr 1, 2022

Conversation

jiangyy12
Copy link
Contributor

@jiangyy12 jiangyy12 commented Mar 6, 2022

Add test cases for participants_controller, versions_controller

@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Mar 6, 2022

Hey @jiangyy12,
Your changes look good to me! 🎉

@expertiza-bot
Copy link
Contributor

expertiza-bot commented Mar 6, 2022

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

Please make sure the PR passes all checks and you have run rubocop -a to autocorrect issues before requesting a review.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

UUID ✅ Nice work.
e222 Your pull request is more than 500 LoC.
Please make sure you did not commit unnecessary changes, such as schema.rb, node_modules, change logs.
c951 You should commit changes to the DB schema (db/schema.rb) only if you have created new DB migrations.
Please double check your code. If you did not aim to change the DB, please revert the DB schema changes.
ecaa There are code changes, but no corresponding tests.
Please include tests if this PR introduces any modifications in behavior.

Generated by expertiza-bot

@coveralls
Copy link

Coverage Status

Coverage decreased (-31.5%) to 16.759% when pulling 6b3f395 on jiangyy12:beta into 33b5c64 on expertiza:beta.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-31.5%) to 16.759% when pulling 6b3f395 on jiangyy12:beta into 33b5c64 on expertiza:beta.

@coveralls
Copy link

coveralls commented Mar 6, 2022

Coverage Status

Coverage decreased (-19.3%) to 48.573% when pulling 664746e on jiangyy12:beta into d4b6a68 on expertiza:beta.

Krishna Prasanna Bhamidipati and others added 28 commits March 25, 2022 18:52
@johnbumgardner johnbumgardner merged commit ceb86f8 into expertiza:beta Apr 1, 2022
johnbumgardner added a commit that referenced this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants