Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy PR for travis fail #2293

Closed
wants to merge 54 commits into from
Closed

Dummy PR for travis fail #2293

wants to merge 54 commits into from

Conversation

namanshrimali
Copy link
Contributor

Please set the title of your pull request in the following format: [Project id/Independent study/Issue fix/...]. project name, eg., E904. Integrating courses and assignments on Expertiza with Moodle

We suggest you including the below information in your pull request:

  • A description of the changes proposed in the pull request.
  • @mentions of the person or team responsible for reviewing proposed changes.

About Expertiza Bot

  • If you have any questions about comments given by the expertiza-bot (example), you could create a comment in your pull request with the format /dispute [UUID1] [UUID2] (example) then the professor and TAs will be notified.
  • Here is a video about how to communicate to expertiza-bot.

divyang02 and others added 30 commits January 28, 2022 20:24
@divyang02
changes in gemfile for conflicts
0139ce8
@namanshrimali @divyang02
Updated gem file to work with rails 5
429db27
@divyang02
updated bundler version and ruby dependency
8cca715
ActiveRecord model changes, few config changes
8f14e76
Removed migration changes
feab8cc
Removed migration changes
b2e1575
Reverted migration changes
c9832c3
Reverted all db changes
e015f68
@divyang02
updated migration files to support rails 5 syntax
ca5a1c4
@divyang02
commented protected attr
1118232
added strong parameter check, commented out attr_accessible
71c8509
Merged local with branch
60d0ff9 
Merged local with branch
rails-controller-testing gem
d6d0d37
Merged branch with beta
0619773
@divyang02
fixed migrations and added strong params in assignment_questionnaire_…
8ddc91d 
…controller
@divyang02
added strong params in bookmarks_controller
8b1ba46
@divyang02
fixed strong params in bookmarks_controller
ad82c86
@namanshrimali
Upgraded to rails 5
10e35de
@namanshrimali
Test cases updates and minor fixes
9f1505d
@divyang02
resolved merge conflict and error in assignment_helper
bbefb29
@divyang02
strong params for assignment_questionnaire_controller.rb
5cc310b
@divyang02
strong params for content_pages, markup_styles, profile_controller
d9cacbe
@namanshrimali
Fixed test cases for rails 5.1
dc41961
@divyang02
resolved merge conflict
1b3f42f
@divyang02
added strong params for questions_controller
56841df
@namanshrimali
Rectified test cases for rails 5.1
b427296
@namanshrimali
Rectified test cases for rails 5.1
e00a6a8
@namanshrimali
Rectified test cases for rails 5.1
b9f6c6d
@namanshrimali
Migrated redirection to rails logic
8c1ff93
@divyang02
added strong params for site_controllers_controller.rb
9c8b206
divyang02 and others added 21 commits March 1, 2022 13:42
@divyang02
tag_prompts_controller
afb925b
@johnbumgardner
Merge branch 'beta' into upgrade_rails_to_5
f4f1cd5
@divyang02
fixed strong param redirect bug and added TODO's
b254ba9
@divyang02
Merge branch 'upgrade_rails_to_5' of https://github.com/expertiza/exp…
7037a3f 
…ertiza into upgrade_rails_to_5
@divyang02
lint check spell error
4f24f7c
@divyang02
updated travis ci
f3adc5e
@divyang02
updated travis ci rvm
c6e7be6
@divyang02
travis rvm 2.6.3
38b962f
@divyang02
testing gemfile ruby update for travis
271313d
@divyang02
merge conflicts
03fa2aa
@divyang02
reverting ruby version and editing nokogiri version
249584e
@divyang02
updating travis to ruby version of vcl
61d9a91
@divyang02
changing danger for testing
c55f235
@divyang02
reverting dangerfile changes
5a0072b
@namanshrimali
Minor refactoring for redirects
bb47d00
@namanshrimali
merge remote in local
67636ba 
Merge branch 'upgrade_rails_to_5' of https://github.com/expertiza/expertiza into upgrade_rails_to_5
merging rails 5 branch with beta
1cac9ae 
Merge branch 'beta' into upgrade_rails_to_5
@divyang02
removed bundle exec from travis.yml
8a7c934
@divyang02
travis fix change migration answertags
cc10b60
@divyang02
travis change scores/answers table
a0781c4
@divyang02
added migration to change pk of answers
cbd90ac
@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Mar 8, 2022 •
edited

Hey @namanshrimali,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

@namanshrimali namanshrimali changed the title Dumm PR for travis fail Dummy PR for travis fail Mar 8, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-34.6%) to 13.67% when pulling d212645 on travis_fix5.1 into 33b5c64 on beta.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-34.6%) to 13.67% when pulling d212645 on travis_fix5.1 into 33b5c64 on beta.

@coveralls
Copy link

coveralls commented Mar 10, 2022 •
edited

Coverage Status

Coverage decreased (-7.7%) to 40.598% when pulling d212645 on travis_fix5.1 into 33b5c64 on beta.

@namanshrimali namanshrimali deleted the travis_fix5.1 branch March 10, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@namanshrimali @expertiza-travisci-bot @coveralls @divyang02 @johnbumgardner