Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2209: Testing for join_team_requests_helper, analytic_helper #2318

Merged
merged 25 commits into from
Apr 1, 2022
Merged

E2209: Testing for join_team_requests_helper, analytic_helper #2318

merged 25 commits into from
Apr 1, 2022

Conversation

mkmcary
Copy link
Contributor

@mkmcary mkmcary commented Mar 15, 2022

Team

Program3_DPM

Description of Changes

Added appropriate testing for JoinTeamRequestsHelper and AnalyticHelper classes.

mkmcary and others added 11 commits March 15, 2022 10:55
@mkmcary
Added tests for JoinTeamRequestsHelper display_request_status()
0f126f7
@mkmcary
Updated expected messages for join_team_request_helper_spec.rb.
516f681
@mkmcary
Updated message for accepted status to properly account for double qu…
64e7353 
…otes.
@mkmcary
Updated accepted status message in test to appropriately handle escap…
b4dde7a 
…e characters.
Deleted analytic_helper.rb as it is not used anywhere in the codebase
b9efa41
Removing unused dependencies of gem 'googlecharts'
5b00b67
Removing unused gem 'googlecharts' from Gemfile
f118510
@gargpriyam21
Deleted chart_helper.rb as it is not used anywhere in the expertiza c…
aa28a29 
…odebase
@mkmcary
Removed commented lines from Gemfile, reports_controller.rb, review_m…
c8dcf2a 
…apping_controller.rb.
@mkmcary
Merge pull request #10 from mkmcary/remove_analytic_helper
b8e99cf 
Deleted analytic_helper.rb and removed 'googlecharts' gem
@mkmcary
Merge pull request #11 from mkmcary/remove-chart_helper
a4978b1 
Deleted chart_helper.rb
@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Mar 21, 2022 •
edited

Hey @mkmcary,
Your changes look good to me! 🎉

@expertiza-bot
Copy link
Contributor

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

Please make sure the PR passes all checks and you have run rubocop -a to autocorrect issues before requesting a review.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.
UUID 1 Warning
c51d ⚠️ You are modifying Gemfile or Gemfile.lock, please double check whether it is necessary.
You are suppose to add a new gem only if you have a very good reason. Try to use existing gems instead.
Please revert changes to Gemfile.lock made by the IDE.

Generated by expertiza-bot

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 48.955% when pulling 3e5a873 on mkmcary:e2209-test into 1b64771 on expertiza:beta.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 48.955% when pulling 3e5a873 on mkmcary:e2209-test into 1b64771 on expertiza:beta.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 48.955% when pulling 3e5a873 on mkmcary:e2209-test into 1b64771 on expertiza:beta.

@johnbumgardner johnbumgardner merged commit 92209cc into expertiza:beta Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mkmcary @expertiza-travisci-bot @expertiza-bot @coveralls @johnbumgardner @gargpriyam21