E2217. Refactor questionnaires_controller.rb #2320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleting create_questionnaire because it was not used anywhere
deleting test for create_questionnaire as it was not being used
Moved the @questionnaire assignments to another method, also moved the questionnaire_node creation to another method. This makes create easier to read
fixing rubocop formating errors
removing write spaces from between methods
removing whitespace line 231
fixed create_questionnaire_node method call
|
Hey @War-Keeper, TravisCI finished with status |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 1: create_questionnaire method and tests removed, it didn't get used at all.
Change 2: create method itself is 49 lines long, converted to 3 different methods, with a specific function for better readability.
Change 3: three checks for whether a questionnaire is a QuizQuestionnaire removed.
Change 4: Bad if statements have been fixed
Change 5: Wiki Page updating