Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reputation hamer testing #2357

Merged
merged 10 commits into from Apr 1, 2022

Conversation

joshlin5
Copy link
Contributor

Added two rspec test files to test the reputation web server hamer algorithm:
expertiza/spec/controllers/reputation_web_server_hamer.rb
expertiza/spec/controllers/reputation_mock_web_server_hamer.rb
@efg is the mentor for this team.

@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Mar 28, 2022

Hey @joshlin5,
Your changes look good to me! 🎉

@joshlin5 joshlin5 closed this Mar 28, 2022
@joshlin5 joshlin5 reopened this Mar 28, 2022
@joshlin5
Copy link
Contributor Author

joshlin5 commented Mar 28, 2022

Two commits fail the Travis CI because of the commit: "added gem webmock and net-http". However, in the latest commit, we fixed the mistakes from that commit by removing those gems. The latest commit fails because of the Gemfile as well. However, at a quick glance, we did not change the Gemfile other than adding and removing gem webmock and gem net-http. Thus, these may be errors already in the beta branch. The error seems to be originating from : Git error: command `git clone 'git://github.com/mimemagicrb/mimemagic.git'

@coveralls
Copy link

Coverage Status

Coverage decreased (-32.4%) to 16.915% when pulling d898e70 on joshlin5:reputation_hamer_testing into 1f077bf on expertiza:beta.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-32.4%) to 16.915% when pulling d898e70 on joshlin5:reputation_hamer_testing into 1f077bf on expertiza:beta.

@coveralls
Copy link

Coverage Status

Coverage decreased (-32.4%) to 16.915% when pulling d898e70 on joshlin5:reputation_hamer_testing into 1f077bf on expertiza:beta.

@johnbumgardner johnbumgardner merged commit d40073a into expertiza:beta Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants