E2229 Track the time students look at other submissions #2377
Conversation
|
Hey @Jmanderson1997, |
|
|
||
| </table> | ||
|
|
||
| </div> | ||
|
|
||
| <% def get_link_round_review_time(map_id, round, link) %> |
There was a problem hiding this comment.
functions should not be defined in views
| <% end %> | ||
|
|
||
| <div id="submissionviewingevent"> | ||
| <% reviewee_list = Array.new %> |
There was a problem hiding this comment.
| <% reviewee_list = Array.new %> | |
| <% reviewee_list = [] %> |
use this syntax when you don't initialize the array to anything specific
|
|
||
| <div id="submissionviewingevent"> | ||
| <% reviewee_list = Array.new %> | ||
| <% total_time_list = Array.new %> |
There was a problem hiding this comment.
| <% total_time_list = Array.new %> | |
| <% total_time_list = [] %> |
| <div id="submissionviewingevent"> | ||
| <% reviewee_list = Array.new %> | ||
| <% total_time_list = Array.new %> | ||
| <% timeHash = Hash.new %> |
There was a problem hiding this comment.
| <% timeHash = Hash.new %> | |
| <% time_hash = {} %> |
| <% else %> | ||
| <% link_list.push(submissionviewingevent_entry.link) %> | ||
| <tr> | ||
| <% if @count == 0 %> <!--- print revieweeId,time, round only for the first row--> |
There was a problem hiding this comment.
| <% if @count == 0 %> <!--- print revieweeId,time, round only for the first row--> | |
| <% if @count.zero?%> <!--- print revieweeId,time, round only for the first row--> |
| <%end%> | ||
| </tr> | ||
| <% end %> | ||
| <% @count=@count+1 %> |
There was a problem hiding this comment.
use each_with_index to manage counters
| <% each_link_detail << individual_link_time %> | ||
| <% @per_round_time << each_link_detail %> | ||
| <td align="center"><%= sprintf("%.2f",individual_link_time) %></td> | ||
| <% if @count == 0 %> |
There was a problem hiding this comment.
| <% if @count == 0 %> | |
| <% if @count.zero? %> |
| <th align="right">Time per link (mins)</th> | ||
| <th></th> | ||
| </tr> | ||
| <% @reviewers = Participant.where(user_id: @user.id) %> |
There was a problem hiding this comment.
why are these using the @ symbol
app/helpers/review_mapping_helper.rb
Outdated
| @@ -410,6 +410,30 @@ def get_css_style_for_calibration_report(diff) | |||
| css_class | |||
| end | |||
|
|
|||
| def get_time_spent_on_review_for_certain_team_for_each_round(map_id) | |||
There was a problem hiding this comment.
this name is too long. also dont use 'get' in ruby
|
We are building on the Previous team's implementation, E1989. Their solution wrote to the database often and did not optimize storage space to the desired metric. We have implemented a solution by using the built-in function of pstore to mitigate database interaction and reduce the number of entries in the database significantly. |
Please set the title of your pull request in the following format:
[Project id/Independent study/Issue fix/...]. project name, eg.,E904. Integrating courses and assignments on Expertiza with MoodleWe suggest you including the below information in your pull request:
About Expertiza Bot
/dispute [UUID1] [UUID2](example) then the professor and TAs will be notified.